Message ID | 1328391283.7008.17.camel@joe2Laptop |
---|---|
State | Rejected, archived |
Delegated to: | David Miller |
Headers | show |
From: Joe Perches <joe@perches.com> Date: Sat, 04 Feb 2012 13:34:43 -0800 > Perhaps adding something to CodingStyle is useful? Come on, get real. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sat, 2012-02-04 at 16:40 -0500, David Miller wrote: > From: Joe Perches <joe@perches.com> > Date: Sat, 04 Feb 2012 13:34:43 -0800 > > Perhaps adding something to CodingStyle is useful? > Come on, get real. ;) I'm trying to get you to understand that your commenting style is not what's in CodingStyle and that you are a bit of an outlier for using it. You can repeat it again and again on the list, but not everyone reads it. Notice I didn't sign it either, but I suppose checkpatch could always add something instead... cheers, Joe -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Joe Perches <joe@perches.com> Date: Sat, 04 Feb 2012 13:50:59 -0800 > On Sat, 2012-02-04 at 16:40 -0500, David Miller wrote: >> From: Joe Perches <joe@perches.com> >> Date: Sat, 04 Feb 2012 13:34:43 -0800 >> > Perhaps adding something to CodingStyle is useful? >> Come on, get real. > > ;) > > I'm trying to get you to understand that your > commenting style is not what's in CodingStyle > and that you are a bit of an outlier for using > it. So do you think my way is superior or inferior to the CodingStyle suggestion? Explain. If you think my way is better, then submit a patch to change it for everyone, not just networking. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sat, 2012-02-04 at 16:53 -0500, David Miller wrote: > From: Joe Perches <joe@perches.com> > > I'm trying to get you to understand that your > > commenting style is not what's in CodingStyle > > and that you are a bit of an outlier for using > > it. > So do you think my way is superior or inferior to the CodingStyle > suggestion? I think it doesn't matter enough to care about it and I generally use relatively height limited screens (100x 50y or so). cheers, Joe -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/CodingStyle b/Documentation/CodingStyle index 2b90d32..65e82e4 100644 --- a/Documentation/CodingStyle +++ b/Documentation/CodingStyle @@ -454,6 +454,14 @@ The preferred style for long (multi-line) comments is: * with beginning and ending almost-blank lines. */ +Unless the files are in net or drivers/net where David Miller +prefers the vertically shorter: + + /* This is the preferred style for multi-line + * comments in the net and drivers/net directories. + * Please use it consistently. + */ + It's also important to comment data, whether they are basic types or derived types. To this end, use just one data declaration per line (no commas for multiple data declarations). This leaves you room for a small comment on each