From patchwork Sat Feb 4 08:02:51 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 139546 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 6E69D104792 for ; Sat, 4 Feb 2012 19:40:41 +1100 (EST) Received: from localhost ([::1]:60272 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RtbAg-0004Cl-Tz for incoming@patchwork.ozlabs.org; Sat, 04 Feb 2012 03:40:34 -0500 Received: from eggs.gnu.org ([140.186.70.92]:34835) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rtaam-000265-LC for qemu-devel@nongnu.org; Sat, 04 Feb 2012 03:03:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rtaah-0005IN-1v for qemu-devel@nongnu.org; Sat, 04 Feb 2012 03:03:26 -0500 Received: from mail-wi0-f173.google.com ([209.85.212.173]:54242) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rtaag-0005ED-2T for qemu-devel@nongnu.org; Sat, 04 Feb 2012 03:03:22 -0500 Received: by mail-wi0-f173.google.com with SMTP id hi20so3684797wib.4 for ; Sat, 04 Feb 2012 00:03:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=sender:from:to:subject:date:message-id:x-mailer:in-reply-to :references; bh=38of6plFWoEHTUqN0LHa+dEnNGBlux8eFaI97as0MuM=; b=Pq8QxC9vn8lIC4rNpKuxOk5s+yyrQ/zSex3LuxGPjea1jjcSwIIuBeYjQp9k2sz56L VpvqG0DvxoCl0iNxcb2V21Ew5ucT3jZk8Z2IAP8u8+W+sFxZbUfgo87ODZJkNWGb3/Lv wdRdd1kvb99v2BMCDVmL45ifsswdHQcd6j6b0= Received: by 10.180.84.105 with SMTP id x9mr1825951wiy.19.1328342601666; Sat, 04 Feb 2012 00:03:21 -0800 (PST) Received: from yakj.usersys.redhat.com.ACCOR.COM (218.104-246-81.adsl-static.isp.belgacom.be. [81.246.104.218]) by mx.google.com with ESMTPS id m8sm24963019wia.11.2012.02.04.00.03.20 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 04 Feb 2012 00:03:21 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Sat, 4 Feb 2012 09:02:51 +0100 Message-Id: <1328342577-25732-22-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.7.7.6 In-Reply-To: <1328342577-25732-1-git-send-email-pbonzini@redhat.com> References: <1328342577-25732-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.212.173 Subject: [Qemu-devel] [PATCH v2 21/27] qdev: fix off-by-one X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Integer properties did not work. Signed-off-by: Paolo Bonzini Reviewed-by: Anthony Liguori --- hw/qdev-properties.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c index d69a987..debb37f 100644 --- a/hw/qdev-properties.c +++ b/hw/qdev-properties.c @@ -151,7 +151,7 @@ static void set_int8(Object *obj, Visitor *v, void *opaque, error_propagate(errp, local_err); return; } - if (value > prop->info->min && value <= prop->info->max) { + if (value >= prop->info->min && value <= prop->info->max) { *ptr = value; } else { error_set(errp, QERR_PROPERTY_VALUE_OUT_OF_RANGE, @@ -259,7 +259,7 @@ static void set_int16(Object *obj, Visitor *v, void *opaque, error_propagate(errp, local_err); return; } - if (value > prop->info->min && value <= prop->info->max) { + if (value >= prop->info->min && value <= prop->info->max) { *ptr = value; } else { error_set(errp, QERR_PROPERTY_VALUE_OUT_OF_RANGE, @@ -333,7 +333,7 @@ static void set_int32(Object *obj, Visitor *v, void *opaque, error_propagate(errp, local_err); return; } - if (value > prop->info->min && value <= prop->info->max) { + if (value >= prop->info->min && value <= prop->info->max) { *ptr = value; } else { error_set(errp, QERR_PROPERTY_VALUE_OUT_OF_RANGE,