From patchwork Fri Feb 3 11:48:21 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Pisati X-Patchwork-Id: 139357 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from chlorine.canonical.com (chlorine.canonical.com [91.189.94.204]) by ozlabs.org (Postfix) with ESMTP id 48A03104792 for ; Fri, 3 Feb 2012 22:48:39 +1100 (EST) Received: from localhost ([127.0.0.1] helo=chlorine.canonical.com) by chlorine.canonical.com with esmtp (Exim 4.71) (envelope-from ) id 1RtHcw-0001AM-M1; Fri, 03 Feb 2012 11:48:26 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by chlorine.canonical.com with esmtp (Exim 4.71) (envelope-from ) id 1RtHct-0001A3-Nc for kernel-team@lists.ubuntu.com; Fri, 03 Feb 2012 11:48:23 +0000 Received: from 2-230-238-136.ip204.fastwebnet.it ([2.230.238.136] helo=canonical.com) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1RtHct-0006m8-Iv for kernel-team@lists.ubuntu.com; Fri, 03 Feb 2012 11:48:23 +0000 From: Paolo Pisati To: kernel-team@lists.ubuntu.com Subject: [PATCH 1/2] ASoC: ABE: disable 16bits support on MM_UL path Date: Fri, 3 Feb 2012 12:48:21 +0100 Message-Id: <1328269702-6073-2-git-send-email-paolo.pisati@canonical.com> X-Mailer: git-send-email 1.7.8.3 In-Reply-To: <1328269702-6073-1-git-send-email-paolo.pisati@canonical.com> References: <1328269702-6073-1-git-send-email-paolo.pisati@canonical.com> X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.13 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: kernel-team-bounces@lists.ubuntu.com Errors-To: kernel-team-bounces@lists.ubuntu.com From: Sebastien Guiriec ASoC: ABE: disable 16bits support on MM_UL path 16 bits support is broken on MM_UL path, resulting in a noisy channel on stereo record. This work-around disables 16bits support (32bits remains). If required, the format conversion shall be handled by SW layers (alsa). Another alternative is to use MM_UL2 path (that properly supports 16bits). Example how to setup and test MM_UL2: amixer cset name='MUX_UL10' 11 amixer cset name='MUX_UL11' 12 arecord -v -D plughw:0,1 -d 5 -f S16_LE -c 2 -r 48000 record.wav Signed-off-by: Sebastien Jan (cherry picked from http://dev.omapzoom.org/?p=integration%2Fkernel-ubuntu.git;a=commitdiff_plain;h=8b5836d9539d23c4876a68e155a967a0b8a98c7e) Signed-off-by: Paolo Pisati --- sound/soc/omap/omap-abe.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/sound/soc/omap/omap-abe.c b/sound/soc/omap/omap-abe.c index 4c9e91f..83e1204 100644 --- a/sound/soc/omap/omap-abe.c +++ b/sound/soc/omap/omap-abe.c @@ -1458,7 +1458,7 @@ static struct snd_soc_dai_driver omap_abe_dai[] = { .channels_min = 2, .channels_max = 8, .rates = SNDRV_PCM_RATE_48000, - .formats = OMAP_ABE_FORMATS, + .formats = SNDRV_PCM_FMTBIT_S32_LE, }, .ops = &omap_abe_dai_ops, .widgets = mm1_widgets,