Patchwork [1/2] ASoC: ABE: disable 16bits support on MM_UL path

login
register
mail settings
Submitter Paolo Pisati
Date Feb. 3, 2012, 11:48 a.m.
Message ID <1328269702-6073-2-git-send-email-paolo.pisati@canonical.com>
Download mbox | patch
Permalink /patch/139357/
State New
Headers show

Comments

Paolo Pisati - Feb. 3, 2012, 11:48 a.m.
From: Sebastien Guiriec <s-guiriec@ti.com>

ASoC: ABE: disable 16bits support on MM_UL path

16 bits support is broken on MM_UL path, resulting in
a noisy channel on stereo record.

This work-around disables 16bits support (32bits remains).

If required, the format conversion shall be handled by SW layers (alsa).

Another alternative is to use MM_UL2 path (that properly supports 16bits).
Example how to setup and test MM_UL2:
 amixer cset name='MUX_UL10' 11
 amixer cset name='MUX_UL11' 12
 arecord -v -D plughw:0,1 -d 5 -f S16_LE -c 2 -r 48000 record.wav

Signed-off-by: Sebastien Jan <s-jan@ti.com>

(cherry picked from http://dev.omapzoom.org/?p=integration%2Fkernel-ubuntu.git;a=commitdiff_plain;h=8b5836d9539d23c4876a68e155a967a0b8a98c7e)

Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
---
 sound/soc/omap/omap-abe.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Patch

diff --git a/sound/soc/omap/omap-abe.c b/sound/soc/omap/omap-abe.c
index 4c9e91f..83e1204 100644
--- a/sound/soc/omap/omap-abe.c
+++ b/sound/soc/omap/omap-abe.c
@@ -1458,7 +1458,7 @@  static struct snd_soc_dai_driver omap_abe_dai[] = {
 			.channels_min = 2,
 			.channels_max = 8,
 			.rates = SNDRV_PCM_RATE_48000,
-			.formats = OMAP_ABE_FORMATS,
+			.formats = SNDRV_PCM_FMTBIT_S32_LE,
 		},
 		.ops = &omap_abe_dai_ops,
 		.widgets = mm1_widgets,