Patchwork [7/8] mtd: spear_smi: initialize writebufsize

login
register
mail settings
Submitter Artem Bityutskiy
Date Feb. 3, 2012, 8:43 a.m.
Message ID <7720c371a73549c301023b95ab0f8eaad7ebc6a9.1328257053.git.artem.bityutskiy@linux.intel.com>
Download mbox | patch
Permalink /patch/139320/
State New
Headers show

Comments

Artem Bityutskiy - Feb. 3, 2012, 8:43 a.m.
From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>

The writebufsize concept was introduce by commit
"0e4ca7e mtd: add writebufsize field to mtd_info struct" and it represents
the maximum amount of data the device writes to the media at a time. This is
an important parameter for UBIFS which is used during recovery and which
basically defines how big a corruption caused by a power cut can be.

Set writebufsize to the flash page size because it is the maximum amount of
data it writes at a time.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Cc: Stefan Roese <sr@denx.de>
Cc: Shiraz Hashim <shiraz.hashim@st.com>
Cc: spear--sw-devel@lists.codex.cro.st.com
---
 drivers/mtd/devices/spear_smi.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Stefan Roese - Feb. 3, 2012, 8:45 a.m.
On Friday 03 February 2012 09:43:13 Artem Bityutskiy wrote:
> From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> 
> The writebufsize concept was introduce by commit
> "0e4ca7e mtd: add writebufsize field to mtd_info struct" and it represents
> the maximum amount of data the device writes to the media at a time. This
> is an important parameter for UBIFS which is used during recovery and
> which basically defines how big a corruption caused by a power cut can be.
> 
> Set writebufsize to the flash page size because it is the maximum amount of
> data it writes at a time.
> 
> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> Cc: Stefan Roese <sr@denx.de>
> Cc: Shiraz Hashim <shiraz.hashim@st.com>
> Cc: spear--sw-devel@lists.codex.cro.st.com

Acked-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

Patch

diff --git a/drivers/mtd/devices/spear_smi.c b/drivers/mtd/devices/spear_smi.c
index 77bcb0b..b4c02d6 100644
--- a/drivers/mtd/devices/spear_smi.c
+++ b/drivers/mtd/devices/spear_smi.c
@@ -847,6 +847,7 @@  static int spear_smi_setup_banks(struct platform_device *pdev, u32 bank)
 	flash->mtd.size = flash_info->size;
 	flash->mtd.erasesize = flash_devices[flash_index].sectorsize;
 	flash->page_size = flash_devices[flash_index].pagesize;
+	flash->mtd.writebufsize = flash->page_size;
 	flash->erase_cmd = flash_devices[flash_index].erase_cmd;
 	flash->mtd._erase = spear_mtd_erase;
 	flash->mtd._read = spear_mtd_read;