Patchwork Regression 3.2 -> 3.3-rc1 10 sec hang at boot and resume, COMRESET failed

login
register
mail settings
Submitter Lin Ming
Date Feb. 3, 2012, 8:27 a.m.
Message ID <1328257660.15079.30.camel@minggr>
Download mbox | patch
Permalink /patch/139313/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Lin Ming - Feb. 3, 2012, 8:27 a.m.
On Fri, 2012-02-03 at 14:43 +0900, Norbert Preining wrote:
> On Fr, 03 Feb 2012, Lin Ming wrote:
> > > I didn't try to revert that commit on top of HEAD.
> > 
> > Please revert that commit to test.
> > That helps us to make sure we find the exact bad commit.
> 
> Confirmed. Reverted 7faa33da9b7 on top of 6c073a7ee250 made
> the boot delay go away. dmesg from this boot attached.

Dig into the code, but I can't find where the problem is.

Anyway, does below DEBUG patch help?
Let's always stop the engine during hard reset.



> 
> Best wishes
> 
> Norbert
> ------------------------------------------------------------------------
> Norbert Preining            preining@{jaist.ac.jp, logic.at, debian.org}
> JAIST, Japan                                 TeX Live & Debian Developer
> DSA: 0x09C5B094   fp: 14DF 2E6C 0307 BE6D AD76  A9C0 D2BF 4AA3 09C5 B094
> ------------------------------------------------------------------------
> PELUTHO (n.) A South American ball game. The balls are whacked against
> a brick wall with a stout wooden bat until the prisoner confesses.
> 			--- Douglas Adams, The Meaning of Liff


--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Norbert Preining - Feb. 6, 2012, 12:46 a.m.
Hi Lin,


sorry for the delay, weekend I was off ...

On Fr, 03 Feb 2012, Lin Ming wrote:
> > Confirmed. Reverted 7faa33da9b7 on top of 6c073a7ee250 made
> > the boot delay go away. dmesg from this boot attached.
> 
> Dig into the code, but I can't find where the problem is.
> 
> Anyway, does below DEBUG patch help?
> Let's always stop the engine during hard reset.

If you meant: 
  "Try that patch on top of HEAD *without* reverting 7faa33da9b7?"
then I can report that it does NOT help. With *only* this patch I still
get 10sec delay, and otherwise nothing changes.


Best wishes

Norbert
------------------------------------------------------------------------
Norbert Preining            preining@{jaist.ac.jp, logic.at, debian.org}
JAIST, Japan                                 TeX Live & Debian Developer
DSA: 0x09C5B094   fp: 14DF 2E6C 0307 BE6D AD76  A9C0 D2BF 4AA3 09C5 B094
------------------------------------------------------------------------
YESNABY (n.)
A 'yes, maybe' which means 'no'.
			--- Douglas Adams, The Meaning of Liff
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c
index a72bfd0..8fef702 100644
--- a/drivers/ata/libahci.c
+++ b/drivers/ata/libahci.c
@@ -578,10 +578,6 @@  int ahci_stop_engine(struct ata_port *ap)
 
 	tmp = readl(port_mmio + PORT_CMD);
 
-	/* check if the HBA is idle */
-	if ((tmp & (PORT_CMD_START | PORT_CMD_LIST_ON)) == 0)
-		return 0;
-
 	/* setting HBA to idle */
 	tmp &= ~PORT_CMD_START;
 	writel(tmp, port_mmio + PORT_CMD);