| Message ID | 1328217177-32745-11-git-send-email-sw@weilnetz.de |
|---|---|
| State | Superseded |
| Headers | show |
On 02.02.2012, at 22:12, Stefan Weil wrote: > Remove some include statements which are not needed. Are these redundant or do they just happen to be unnecessary because of unused debug #ifdefs? Alex > > Cc: Alexander Graf <agraf@suse.de> > Signed-off-by: Stefan Weil <sw@weilnetz.de> > --- > target-ppc/helper.c | 6 ------ > target-ppc/translate.c | 6 ------ > 2 files changed, 0 insertions(+), 12 deletions(-) > > diff --git a/target-ppc/helper.c b/target-ppc/helper.c > index 5847453..455dcc0 100644 > --- a/target-ppc/helper.c > +++ b/target-ppc/helper.c > @@ -16,15 +16,9 @@ > * You should have received a copy of the GNU Lesser General Public > * License along with this library; if not, see <http://www.gnu.org/licenses/>. > */ > -#include <stdarg.h> > -#include <stdlib.h> > -#include <stdio.h> > -#include <string.h> > -#include <inttypes.h> > > #include "cpu.h" > #include "helper_regs.h" > -#include "qemu-common.h" > #include "kvm.h" > #include "kvm_ppc.h" > #include "cpus.h" > diff --git a/target-ppc/translate.c b/target-ppc/translate.c > index 66eae30..74ad855 100644 > --- a/target-ppc/translate.c > +++ b/target-ppc/translate.c > @@ -17,16 +17,10 @@ > * You should have received a copy of the GNU Lesser General Public > * License along with this library; if not, see <http://www.gnu.org/licenses/>. > */ > -#include <stdarg.h> > -#include <stdlib.h> > -#include <stdio.h> > -#include <string.h> > -#include <inttypes.h> > > #include "cpu.h" > #include "disas.h" > #include "tcg-op.h" > -#include "qemu-common.h" > #include "host-utils.h" > > #include "helper.h" > -- > 1.7.7.3 >
Am 02.02.2012 22:26, schrieb Alexander Graf: > > On 02.02.2012, at 22:12, Stefan Weil wrote: > >> Remove some include statements which are not needed. > > Are these redundant or do they just happen to be unnecessary because > of unused debug #ifdefs? > > > Alex They are redundant because cpu.h includes qemu-common.h which includes the standard include files. Cheers, Stefan
On 02.02.2012, at 23:46, Stefan Weil wrote: > Am 02.02.2012 22:26, schrieb Alexander Graf: >> >> On 02.02.2012, at 22:12, Stefan Weil wrote: >> >>> Remove some include statements which are not needed. >> >> Are these redundant or do they just happen to be unnecessary because of unused debug #ifdefs? >> >> >> Alex > > They are redundant because cpu.h includes qemu-common.h which includes > the standard include files. Well, then: Acked-by: Alexander Graf <agraf@suse.de> Alex
diff --git a/target-ppc/helper.c b/target-ppc/helper.c index 5847453..455dcc0 100644 --- a/target-ppc/helper.c +++ b/target-ppc/helper.c @@ -16,15 +16,9 @@ * You should have received a copy of the GNU Lesser General Public * License along with this library; if not, see <http://www.gnu.org/licenses/>. */ -#include <stdarg.h> -#include <stdlib.h> -#include <stdio.h> -#include <string.h> -#include <inttypes.h> #include "cpu.h" #include "helper_regs.h" -#include "qemu-common.h" #include "kvm.h" #include "kvm_ppc.h" #include "cpus.h" diff --git a/target-ppc/translate.c b/target-ppc/translate.c index 66eae30..74ad855 100644 --- a/target-ppc/translate.c +++ b/target-ppc/translate.c @@ -17,16 +17,10 @@ * You should have received a copy of the GNU Lesser General Public * License along with this library; if not, see <http://www.gnu.org/licenses/>. */ -#include <stdarg.h> -#include <stdlib.h> -#include <stdio.h> -#include <string.h> -#include <inttypes.h> #include "cpu.h" #include "disas.h" #include "tcg-op.h" -#include "qemu-common.h" #include "host-utils.h" #include "helper.h"
Remove some include statements which are not needed. Cc: Alexander Graf <agraf@suse.de> Signed-off-by: Stefan Weil <sw@weilnetz.de> --- target-ppc/helper.c | 6 ------ target-ppc/translate.c | 6 ------ 2 files changed, 0 insertions(+), 12 deletions(-)