From patchwork Wed Feb 1 20:05:53 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Williams X-Patchwork-Id: 138984 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from maxx.maxx.shmoo.com (maxx.shmoo.com [205.134.188.171]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "maxx.shmoo.com", Issuer "CA Cert Signing Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 9ECD2B6EEA for ; Thu, 2 Feb 2012 07:04:51 +1100 (EST) Received: from localhost (localhost [127.0.0.1]) by maxx.maxx.shmoo.com (Postfix) with ESMTP id A81C417C011; Wed, 1 Feb 2012 15:04:49 -0500 (EST) X-Virus-Scanned: amavisd-new at maxx.shmoo.com Received: from maxx.maxx.shmoo.com ([127.0.0.1]) by localhost (maxx.shmoo.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aMXHYkpzqNvS; Wed, 1 Feb 2012 15:04:49 -0500 (EST) Received: from maxx.shmoo.com (localhost [127.0.0.1]) by maxx.maxx.shmoo.com (Postfix) with ESMTP id 318949D0C8; Wed, 1 Feb 2012 15:04:49 -0500 (EST) X-Original-To: mailman-post+hostap@maxx.shmoo.com Delivered-To: mailman-post+hostap@maxx.shmoo.com Received: from localhost (localhost [127.0.0.1]) by maxx.maxx.shmoo.com (Postfix) with ESMTP id 2C7709D0C8 for ; Wed, 1 Feb 2012 15:04:48 -0500 (EST) X-Virus-Scanned: amavisd-new at maxx.shmoo.com Received: from maxx.maxx.shmoo.com ([127.0.0.1]) by localhost (maxx.shmoo.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id X1MTRQIhXAen for ; Wed, 1 Feb 2012 15:04:48 -0500 (EST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by maxx.maxx.shmoo.com (Postfix) with ESMTP id D9E729D089 for ; Wed, 1 Feb 2012 15:04:47 -0500 (EST) Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q11K4k6O025174 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 1 Feb 2012 15:04:46 -0500 Received: from [10.3.234.31] (vpn-234-31.phx2.redhat.com [10.3.234.31]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q11K4jDB006953; Wed, 1 Feb 2012 15:04:46 -0500 Message-ID: <1328126753.7012.14.camel@dcbw.foobar.com> Subject: Re: [PATCH] (libeap) Please review an old patch From: Dan Williams To: Mathieu Trudel-Lapierre Date: Wed, 01 Feb 2012 14:05:53 -0600 In-Reply-To: References: Mime-Version: 1.0 X-Scanned-By: MIMEDefang 2.68 on 10.5.11.25 Cc: hostap@lists.shmoo.com X-BeenThere: hostap@lists.shmoo.com X-Mailman-Version: 2.1.9 Precedence: list List-Id: HostAP Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: hostap-bounces@lists.shmoo.com Errors-To: hostap-bounces@lists.shmoo.com On Mon, 2012-01-30 at 19:35 -0500, Mathieu Trudel-Lapierre wrote: > Hi, > > Inaky Perez-Gonzalez once submitted a patch to support splitting > wpasupplicant up to provide libeap separately: > > http://lists.shmoo.com/pipermail/hostap/2010-October/021795.html > > Would it be possible to review this patch again, or let me know what > kind of work is still required to get this acceptable? It needs a bit of updating for hostap 1.0+, something like: But would be nice to get this integrated so we don't have to custom patch stuff for the Intel WiMAX stack. Dan > Sorry for the rather weird request ;) > > Thanks, and regards. > > Mathieu Trudel-Lapierre > Freenode: cyphermox, Jabber: mathieu.tl@gmail.com > 4096R/EE018C93 1967 8F7D 03A1 8F38 732E FF82 C126 33E1 EE01 8C93 > _______________________________________________ > HostAP mailing list > HostAP@lists.shmoo.com > http://lists.shmoo.com/mailman/listinfo/hostap diff --git a/wpa_supplicant-0.7.2-generate-libeap-peer.patch b/wpa_supplicant-0.7.2-generate-libeap-peer.patch index 915afa3..f4c38d2 100644 --- a/wpa_supplicant-0.7.2-generate-libeap-peer.patch +++ b/wpa_supplicant-0.7.2-generate-libeap-peer.patch @@ -42,7 +42,7 @@ diff --git a/src/eap_peer/Makefile b/src/eap_peer/Makefile index 3651056..58c067a 100644 --- a/src/eap_peer/Makefile +++ b/src/eap_peer/Makefile -@@ -1,11 +1,190 @@ +@@ -1,11 +1,192 @@ -all: - @echo Nothing to be made. +LIBEAP_NAME = libeap @@ -83,6 +83,7 @@ index 3651056..58c067a 100644 +override CFLAGS += -I ../../wpa_supplicant + +OBJS_both += ../utils/common.o ++OBJS_both += ../utils/eloop.o +OBJS_both += ../utils/os_unix.o +OBJS_both += ../utils/wpa_debug.o +OBJS_both += ../utils/base64.o @@ -97,6 +98,7 @@ index 3651056..58c067a 100644 +OBJS_both += ../crypto/aes-omac1.o +OBJS_both += ../crypto/ms_funcs.o +OBJS_both += ../crypto/sha256.o ++OBJS_both += ../crypto/random.o + + +OBJS_both += ../eap_common/eap_peap_common.o