| Message ID | 20120201185510.GA8542@linux.vnet.ibm.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
On 12-02-01 01:55 PM, Paul E. McKenney wrote: > The variable cpus_in_crash gets a defined-but-not-used warning when > CONFIG_SMP=n, so fix by placing the variable under ifdef. I think Ben already merged a similar fix. http://patchwork.ozlabs.org/patch/136549/ P. > > Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> > > diff --git a/arch/powerpc/kernel/crash.c b/arch/powerpc/kernel/crash.c > index 28be345..eb3384e 100644 > --- a/arch/powerpc/kernel/crash.c > +++ b/arch/powerpc/kernel/crash.c > @@ -46,7 +46,9 @@ > > /* This keeps a track of which one is the crashing cpu. */ > int crashing_cpu = -1; > +#ifdef CONFIG_SMP > static atomic_t cpus_in_crash; > +#endif /* #ifdef CONFIG_SMP */ > static int time_to_dump; > > #define CRASH_HANDLER_MAX 3 >
On Wed, Feb 01, 2012 at 03:28:34PM -0500, Paul Gortmaker wrote: > On 12-02-01 01:55 PM, Paul E. McKenney wrote: > > The variable cpus_in_crash gets a defined-but-not-used warning when > > CONFIG_SMP=n, so fix by placing the variable under ifdef. > > I think Ben already merged a similar fix. > > http://patchwork.ozlabs.org/patch/136549/ > > P. Linus's tree does now have cpus_in_crash, so agreed. Sorry for the noise! Thanx, Paul > > Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> > > > > diff --git a/arch/powerpc/kernel/crash.c b/arch/powerpc/kernel/crash.c > > index 28be345..eb3384e 100644 > > --- a/arch/powerpc/kernel/crash.c > > +++ b/arch/powerpc/kernel/crash.c > > @@ -46,7 +46,9 @@ > > > > /* This keeps a track of which one is the crashing cpu. */ > > int crashing_cpu = -1; > > +#ifdef CONFIG_SMP > > static atomic_t cpus_in_crash; > > +#endif /* #ifdef CONFIG_SMP */ > > static int time_to_dump; > > > > #define CRASH_HANDLER_MAX 3 > > >
diff --git a/arch/powerpc/kernel/crash.c b/arch/powerpc/kernel/crash.c index 28be345..eb3384e 100644 --- a/arch/powerpc/kernel/crash.c +++ b/arch/powerpc/kernel/crash.c @@ -46,7 +46,9 @@ /* This keeps a track of which one is the crashing cpu. */ int crashing_cpu = -1; +#ifdef CONFIG_SMP static atomic_t cpus_in_crash; +#endif /* #ifdef CONFIG_SMP */ static int time_to_dump; #define CRASH_HANDLER_MAX 3
The variable cpus_in_crash gets a defined-but-not-used warning when CONFIG_SMP=n, so fix by placing the variable under ifdef. Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>