| Message ID | m1zkd45411.fsf_-_@fess.ebiederm.org |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
On 01/31/2012 03:40 PM, Eric W. Biederman wrote: > > This fixes a bug introduced with sysfs name hashes where renaming a > network device appears to succeed but silently makes the sysfs files for > that network device inaccessible. > > In at least one configuration this bug has stopped networking from > coming up during boot. > > Signed-off-by: Eric W. Biederman <ebiederm@xmission.com> It works for me. Thanks. Tested-by: Jiri Slaby <jslaby@suse.cz> > --- > fs/sysfs/dir.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/fs/sysfs/dir.c b/fs/sysfs/dir.c > index ea64d01..dd3779c 100644 > --- a/fs/sysfs/dir.c > +++ b/fs/sysfs/dir.c > @@ -872,6 +872,7 @@ int sysfs_rename(struct sysfs_dirent *sd, > > dup_name = sd->s_name; > sd->s_name = new_name; > + sd->s_hash = sysfs_name_hash(sd->s_ns, sd->s_name); > } > > /* Move to the appropriate place in the appropriate directories rbtree. */
On Tue, Jan 31, 2012 at 06:40:26AM -0800, Eric W. Biederman wrote: > > This fixes a bug introduced with sysfs name hashes where renaming a > network device appears to succeed but silently makes the sysfs files for > that network device inaccessible. > > In at least one configuration this bug has stopped networking from > coming up during boot. > > Signed-off-by: Eric W. Biederman <ebiederm@xmission.com> > --- > fs/sysfs/dir.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) Thanks for this, I'll queue it up later today. greg k-h -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/sysfs/dir.c b/fs/sysfs/dir.c index ea64d01..dd3779c 100644 --- a/fs/sysfs/dir.c +++ b/fs/sysfs/dir.c @@ -872,6 +872,7 @@ int sysfs_rename(struct sysfs_dirent *sd, dup_name = sd->s_name; sd->s_name = new_name; + sd->s_hash = sysfs_name_hash(sd->s_ns, sd->s_name); } /* Move to the appropriate place in the appropriate directories rbtree. */
This fixes a bug introduced with sysfs name hashes where renaming a network device appears to succeed but silently makes the sysfs files for that network device inaccessible. In at least one configuration this bug has stopped networking from coming up during boot. Signed-off-by: Eric W. Biederman <ebiederm@xmission.com> --- fs/sysfs/dir.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)