Patchwork powerpc/85xx: Fix compiler error with THIS_MODULE and related

login
register
mail settings
Submitter Claudiu Manoil
Date Jan. 31, 2012, 10:15 a.m.
Message ID <1328004939-29766-1-git-send-email-claudiu.manoil@freescale.com>
Download mbox | patch
Permalink /patch/138752/
State Superseded
Headers show

Comments

Claudiu Manoil - Jan. 31, 2012, 10:15 a.m.
CC      arch/powerpc/sysdev/fsl_85xx_l2ctlr.o
arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:209:13: error: 'THIS_MODULE' undeclared here (not in a function)
arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:229:20: error: expected declaration specifiers or '...' before string constant
cc1: warnings being treated as errors
arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:229:1: error: data definition has no type or storage class
arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:229:1: error: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION'
arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:229:20: error: function declaration isn't a prototype
arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:230:16: error: expected declaration specifiers or '...' before string constant
arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:230:1: error: data definition has no type or storage class
arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:230:1: error: type defaults to 'int' in declaration of 'MODULE_LICENSE'
arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:230:16: error: function declaration isn't a prototype
make[1]: *** [arch/powerpc/sysdev/fsl_85xx_l2ctlr.o] Error 1

...

  CC      arch/powerpc/sysdev/fsl_85xx_cache_sram.o
cc1: warnings being treated as errors
arch/powerpc/sysdev/fsl_85xx_cache_sram.c:69:1: error: data definition has no type or storage class
arch/powerpc/sysdev/fsl_85xx_cache_sram.c:69:1: error: type defaults to 'int' in declaration of 'EXPORT_SYMBOL'
arch/powerpc/sysdev/fsl_85xx_cache_sram.c:69:1: error: parameter names (without types) in function declaration
arch/powerpc/sysdev/fsl_85xx_cache_sram.c:80:1: error: data definition has no type or storage class
arch/powerpc/sysdev/fsl_85xx_cache_sram.c:80:1: error: type defaults to 'int' in declaration of 'EXPORT_SYMBOL'
arch/powerpc/sysdev/fsl_85xx_cache_sram.c:80:1: error: parameter names (without types) in function declaration
make[1]: *** [arch/powerpc/sysdev/fsl_85xx_cache_sram.o] Error 1

Signed-off-by: Claudiu Manoil <claudiu.manoil@freescale.com>
---
 arch/powerpc/sysdev/fsl_85xx_cache_sram.c |    1 +
 arch/powerpc/sysdev/fsl_85xx_l2ctlr.c     |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)
Scott Wood - Jan. 31, 2012, 7:12 p.m.
On 01/31/2012 04:15 AM, Claudiu Manoil wrote:
>    CC      arch/powerpc/sysdev/fsl_85xx_l2ctlr.o
> arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:209:13: error: 'THIS_MODULE' undeclared here (not in a function)
> arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:229:20: error: expected declaration specifiers or '...' before string constant
> cc1: warnings being treated as errors
> arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:229:1: error: data definition has no type or storage class
> arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:229:1: error: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION'
> arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:229:20: error: function declaration isn't a prototype
> arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:230:16: error: expected declaration specifiers or '...' before string constant
> arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:230:1: error: data definition has no type or storage class
> arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:230:1: error: type defaults to 'int' in declaration of 'MODULE_LICENSE'
> arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:230:16: error: function declaration isn't a prototype
> make[1]: *** [arch/powerpc/sysdev/fsl_85xx_l2ctlr.o] Error 1
> 
> ...
> 
>   CC      arch/powerpc/sysdev/fsl_85xx_cache_sram.o
> cc1: warnings being treated as errors
> arch/powerpc/sysdev/fsl_85xx_cache_sram.c:69:1: error: data definition has no type or storage class
> arch/powerpc/sysdev/fsl_85xx_cache_sram.c:69:1: error: type defaults to 'int' in declaration of 'EXPORT_SYMBOL'
> arch/powerpc/sysdev/fsl_85xx_cache_sram.c:69:1: error: parameter names (without types) in function declaration
> arch/powerpc/sysdev/fsl_85xx_cache_sram.c:80:1: error: data definition has no type or storage class
> arch/powerpc/sysdev/fsl_85xx_cache_sram.c:80:1: error: type defaults to 'int' in declaration of 'EXPORT_SYMBOL'
> arch/powerpc/sysdev/fsl_85xx_cache_sram.c:80:1: error: parameter names (without types) in function declaration
> make[1]: *** [arch/powerpc/sysdev/fsl_85xx_cache_sram.o] Error 1
> 
> Signed-off-by: Claudiu Manoil <claudiu.manoil@freescale.com>
> ---
>  arch/powerpc/sysdev/fsl_85xx_cache_sram.c |    1 +
>  arch/powerpc/sysdev/fsl_85xx_l2ctlr.c     |    1 +
>  2 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/powerpc/sysdev/fsl_85xx_cache_sram.c b/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
> index 1164158..92cce8d 100644
> --- a/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
> +++ b/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
> @@ -24,6 +24,7 @@
>   */
>  
>  #include <linux/kernel.h>
> +#include <linux/module.h>
>  #include <linux/slab.h>
>  #include <linux/err.h>
>  #include <linux/of_platform.h>
> diff --git a/arch/powerpc/sysdev/fsl_85xx_l2ctlr.c b/arch/powerpc/sysdev/fsl_85xx_l2ctlr.c
> index 5f88797..1957e53 100644
> --- a/arch/powerpc/sysdev/fsl_85xx_l2ctlr.c
> +++ b/arch/powerpc/sysdev/fsl_85xx_l2ctlr.c
> @@ -21,6 +21,7 @@
>   */
>  
>  #include <linux/kernel.h>
> +#include <linux/module.h>
>  #include <linux/of_platform.h>
>  #include <asm/io.h>
>  

I believe <linux/export.h> is what you're supposed to include for this
these days.

-Scott
Manoil Claudiu-B08782 - Feb. 1, 2012, 11:23 a.m.
Hi,

You're right, <linux/export.h> is better for arch/powerpc/sysdev/fsl_85xx_cache_sram.c.
However, it is not enough for arch/powerpc/sysdev/fsl_85xx_l2ctlr.c, as this one is defined as a module.
I'll resend the patch (with <linux/export.h> for fsl_85xx_cache_sram.c), if that's fine with you.

Thanks,
Claudiu

> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Tuesday, January 31, 2012 9:12 PM
> To: Manoil Claudiu-B08782
> Cc: linuxppc-dev@lists.ozlabs.org
> Subject: Re: [PATCH] powerpc/85xx: Fix compiler error with THIS_MODULE
> and related
> 
> On 01/31/2012 04:15 AM, Claudiu Manoil wrote:
> >    CC      arch/powerpc/sysdev/fsl_85xx_l2ctlr.o
> > arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:209:13: error: 'THIS_MODULE'
> > undeclared here (not in a function)
> > arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:229:20: error: expected
> > declaration specifiers or '...' before string constant
> > cc1: warnings being treated as errors
> > arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:229:1: error: data definition
> > has no type or storage class
> > arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:229:1: error: type defaults to
> 'int' in declaration of 'MODULE_DESCRIPTION'
> > arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:229:20: error: function
> > declaration isn't a prototype
> > arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:230:16: error: expected
> > declaration specifiers or '...' before string constant
> > arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:230:1: error: data definition
> > has no type or storage class
> > arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:230:1: error: type defaults to
> 'int' in declaration of 'MODULE_LICENSE'
> > arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:230:16: error: function
> > declaration isn't a prototype
> > make[1]: *** [arch/powerpc/sysdev/fsl_85xx_l2ctlr.o] Error 1
> >
> > ...
> >
> >   CC      arch/powerpc/sysdev/fsl_85xx_cache_sram.o
> > cc1: warnings being treated as errors
> > arch/powerpc/sysdev/fsl_85xx_cache_sram.c:69:1: error: data definition
> > has no type or storage class
> > arch/powerpc/sysdev/fsl_85xx_cache_sram.c:69:1: error: type defaults to
> 'int' in declaration of 'EXPORT_SYMBOL'
> > arch/powerpc/sysdev/fsl_85xx_cache_sram.c:69:1: error: parameter names
> > (without types) in function declaration
> > arch/powerpc/sysdev/fsl_85xx_cache_sram.c:80:1: error: data definition
> > has no type or storage class
> > arch/powerpc/sysdev/fsl_85xx_cache_sram.c:80:1: error: type defaults to
> 'int' in declaration of 'EXPORT_SYMBOL'
> > arch/powerpc/sysdev/fsl_85xx_cache_sram.c:80:1: error: parameter names
> > (without types) in function declaration
> > make[1]: *** [arch/powerpc/sysdev/fsl_85xx_cache_sram.o] Error 1
> >
> > Signed-off-by: Claudiu Manoil <claudiu.manoil@freescale.com>
> > ---
> >  arch/powerpc/sysdev/fsl_85xx_cache_sram.c |    1 +
> >  arch/powerpc/sysdev/fsl_85xx_l2ctlr.c     |    1 +
> >  2 files changed, 2 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
> > b/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
> > index 1164158..92cce8d 100644
> > --- a/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
> > +++ b/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
> > @@ -24,6 +24,7 @@
> >   */
> >
> >  #include <linux/kernel.h>
> > +#include <linux/module.h>
> >  #include <linux/slab.h>
> >  #include <linux/err.h>
> >  #include <linux/of_platform.h>
> > diff --git a/arch/powerpc/sysdev/fsl_85xx_l2ctlr.c
> > b/arch/powerpc/sysdev/fsl_85xx_l2ctlr.c
> > index 5f88797..1957e53 100644
> > --- a/arch/powerpc/sysdev/fsl_85xx_l2ctlr.c
> > +++ b/arch/powerpc/sysdev/fsl_85xx_l2ctlr.c
> > @@ -21,6 +21,7 @@
> >   */
> >
> >  #include <linux/kernel.h>
> > +#include <linux/module.h>
> >  #include <linux/of_platform.h>
> >  #include <asm/io.h>
> >
> 
> I believe <linux/export.h> is what you're supposed to include for this
> these days.
> 
> -Scott

Patch

diff --git a/arch/powerpc/sysdev/fsl_85xx_cache_sram.c b/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
index 1164158..92cce8d 100644
--- a/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
+++ b/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
@@ -24,6 +24,7 @@ 
  */
 
 #include <linux/kernel.h>
+#include <linux/module.h>
 #include <linux/slab.h>
 #include <linux/err.h>
 #include <linux/of_platform.h>
diff --git a/arch/powerpc/sysdev/fsl_85xx_l2ctlr.c b/arch/powerpc/sysdev/fsl_85xx_l2ctlr.c
index 5f88797..1957e53 100644
--- a/arch/powerpc/sysdev/fsl_85xx_l2ctlr.c
+++ b/arch/powerpc/sysdev/fsl_85xx_l2ctlr.c
@@ -21,6 +21,7 @@ 
  */
 
 #include <linux/kernel.h>
+#include <linux/module.h>
 #include <linux/of_platform.h>
 #include <asm/io.h>