From patchwork Tue Jan 31 07:11:03 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Devendra Naga X-Patchwork-Id: 138703 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 715BC1007D1 for ; Tue, 31 Jan 2012 18:12:22 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752439Ab2AaHME (ORCPT ); Tue, 31 Jan 2012 02:12:04 -0500 Received: from mail-yw0-f42.google.com ([209.85.213.42]:61006 "EHLO mail-yw0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751105Ab2AaHMD (ORCPT ); Tue, 31 Jan 2012 02:12:03 -0500 X-Greylist: delayed 2556 seconds by postgrey-1.27 at vger.kernel.org; Tue, 31 Jan 2012 02:12:02 EST Received: by yhfq11 with SMTP id q11so1327452yhf.1 for ; Mon, 30 Jan 2012 23:12:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; bh=N5c0vIPfucrRK55QXOlBS0VRiwJz3SYS1/yAdOmQCD0=; b=KNbQ/Lr/+d6SAAlu7s6f6CLTGNPkXjsSvY69SBnezAFPK51lU3lbrtmO9knc7Vl6k+ zcxzNMWBdl07sn9PwtTm297cFYKhpfN2uAcT+02HJfmQM4nTuNU8aZ6Iv/HOrFvwTl6s M89K4+ogQMgF9/rs+w8jjAmh0Np6b0re4Rrsw= Received: by 10.236.170.130 with SMTP id p2mr10412810yhl.13.1327993921536; Mon, 30 Jan 2012 23:12:01 -0800 (PST) Received: from localhost.localdomain ([203.123.187.226]) by mx.google.com with ESMTPS id m18sm53420576ann.0.2012.01.30.23.11.56 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 30 Jan 2012 23:12:00 -0800 (PST) From: "Devendra.Naga" To: , , , , , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: "Devendra.Naga" Subject: [PATCH] rtlwifi/rtl8192c: in _rtl92c_phy_calculate_bit_shift remove comparing bitmask against 1 Date: Tue, 31 Jan 2012 02:11:03 -0500 Message-Id: <1327993863-6810-1-git-send-email-devendra.aaru@gmail.com> X-Mailer: git-send-email 1.7.5.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: "Devendra.Naga" in _rtl92c_phy_calculate_bit_shift everytime the right shifted bitmask is AND with 1 and compared against 1. i.e. if ((bitmask >> i) & 0x1 == 1) break; which in the if condition is anyway becomes a 1 or 0. Signed-off-by: Devendra.Naga --- drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c b/drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c index 22e998d..a76b223 100644 --- a/drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c +++ b/drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c @@ -177,7 +177,7 @@ u32 _rtl92c_phy_calculate_bit_shift(u32 bitmask) u32 i; for (i = 0; i <= 31; i++) { - if (((bitmask >> i) & 0x1) == 1) + if ((bitmask >> i) & 0x1) break; } return i;