Message ID | 1327927591-28070-1-git-send-email-devendra.aaru@gmail.com |
---|---|
State | Not Applicable, archived |
Delegated to: | David Miller |
Headers | show |
On 01/30/2012 06:46 AM, Devendra.Naga wrote: > From: "Devendra.Naga"<devendra.aaru@gmail.com> > > the return value from _rtl_pci_switch_clk_req is not used by any of its callers. > > Signed-off-by: Devendra.Naga<devendra.aaru@gmail.com> > --- > drivers/net/wireless/rtlwifi/pci.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) The patch is OK, but the patch subject is bad. You should have "[PATCH] rtlwifi:...". Your patch is for rtlwifi, not wireless. Larry > > diff --git a/drivers/net/wireless/rtlwifi/pci.c b/drivers/net/wireless/rtlwifi/pci.c > index 4326fd1..35f4a0d 100644 > --- a/drivers/net/wireless/rtlwifi/pci.c > +++ b/drivers/net/wireless/rtlwifi/pci.c > @@ -198,7 +198,7 @@ static bool _rtl_pci_platform_switch_device_pci_aspm( > } > > /*When we set 0x01 to enable clk request. Set 0x0 to disable clk req.*/ > -static bool _rtl_pci_switch_clk_req(struct ieee80211_hw *hw, u8 value) > +static void _rtl_pci_switch_clk_req(struct ieee80211_hw *hw, u8 value) > { > struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw)); > struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw)); > @@ -208,7 +208,6 @@ static bool _rtl_pci_switch_clk_req(struct ieee80211_hw *hw, u8 value) > if (rtlhal->hw_type == HARDWARE_TYPE_RTL8192SE) > udelay(100); > > - return true; > } > > /*Disable RTL8192SE ASPM& Disable Pci Bridge ASPM*/ -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 2012-01-30 at 17:35 -0600, Larry Finger wrote: > The patch is OK, but the patch subject is bad. You should have "[PATCH] > rtlwifi:...". Your patch is for rtlwifi, not wireless. Hi Devendra. A reasonable rule of thumb is use the deepest directory path basename you can to prefix the patch. Something like: [PATCH] $(basename $(dirname $file)): terse description If you are patching drivers/net/ethernet/realtek/apt.c this becomes: [PATCH] realtek: terse description There are some exceptions though. One of them is if the patch is in staging, prefix with [PATCH] staging: $(basename $(dirname $file)): description cheers, Joe -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Jan 30, 2012 at 6:45 PM, Joe Perches <joe@perches.com> wrote: > On Mon, 2012-01-30 at 17:35 -0600, Larry Finger wrote: >> The patch is OK, but the patch subject is bad. You should have "[PATCH] >> rtlwifi:...". Your patch is for rtlwifi, not wireless. > Will post a new patch, Thanks !! > Hi Devendra. > > A reasonable rule of thumb is use the deepest directory > path basename you can to prefix the patch. > Something like: > > [PATCH] $(basename $(dirname $file)): terse description > > If you are patching drivers/net/ethernet/realtek/apt.c > this becomes: > > [PATCH] realtek: terse description > > There are some exceptions though. One of them > is if the patch is in staging, prefix with > [PATCH] staging: $(basename $(dirname $file)): description > > cheers, Joe > Thanks a lot Joe, will follow your suggestions :). Devendra. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/wireless/rtlwifi/pci.c b/drivers/net/wireless/rtlwifi/pci.c index 4326fd1..35f4a0d 100644 --- a/drivers/net/wireless/rtlwifi/pci.c +++ b/drivers/net/wireless/rtlwifi/pci.c @@ -198,7 +198,7 @@ static bool _rtl_pci_platform_switch_device_pci_aspm( } /*When we set 0x01 to enable clk request. Set 0x0 to disable clk req.*/ -static bool _rtl_pci_switch_clk_req(struct ieee80211_hw *hw, u8 value) +static void _rtl_pci_switch_clk_req(struct ieee80211_hw *hw, u8 value) { struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw)); struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw)); @@ -208,7 +208,6 @@ static bool _rtl_pci_switch_clk_req(struct ieee80211_hw *hw, u8 value) if (rtlhal->hw_type == HARDWARE_TYPE_RTL8192SE) udelay(100); - return true; } /*Disable RTL8192SE ASPM & Disable Pci Bridge ASPM*/