From patchwork Mon Jan 30 08:41:33 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kazuya Mio X-Patchwork-Id: 138530 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id E5109B6EFE for ; Mon, 30 Jan 2012 19:44:22 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753988Ab2A3IoV (ORCPT ); Mon, 30 Jan 2012 03:44:21 -0500 Received: from TYO201.gate.nec.co.jp ([202.32.8.193]:41002 "EHLO tyo201.gate.nec.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753831Ab2A3IoU (ORCPT ); Mon, 30 Jan 2012 03:44:20 -0500 Received: from mailgate3.nec.co.jp ([10.7.69.195]) by tyo201.gate.nec.co.jp (8.13.8/8.13.4) with ESMTP id q0U8gIrT001197; Mon, 30 Jan 2012 17:42:18 +0900 (JST) Received: (from root@localhost) by mailgate3.nec.co.jp (8.11.7/3.7W-MAILGATE-NEC) id q0U8gIo12144; Mon, 30 Jan 2012 17:42:18 +0900 (JST) Received: from mail01b.kamome.nec.co.jp (mail01b.kamome.nec.co.jp [10.25.43.2]) by mailsv.nec.co.jp (8.13.8/8.13.4) with ESMTP id q0U8gHoD017516; Mon, 30 Jan 2012 17:42:17 +0900 (JST) Received: from yonosuke.jp.nec.com ([10.26.220.15] [10.26.220.15]) by mail01b.kamome.nec.co.jp with ESMTP id BT-MMP-638384; Mon, 30 Jan 2012 17:41:33 +0900 Received: from [10.64.168.30] ([10.64.168.30] [10.64.168.30]) by mail.jp.nec.com with ESMTP; Mon, 30 Jan 2012 17:41:33 +0900 Message-ID: <4F2657BD.8030208@sx.jp.nec.com> Date: Mon, 30 Jan 2012 17:41:33 +0900 From: Kazuya Mio User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; ja; rv:1.9.2.18) Gecko/20110613 Thunderbird/3.1.11 MIME-Version: 1.0 To: ext4 , Jan Kara , Andreas Dilger Subject: [PATCH 2/2] ext3: Don't update ctime in ext3_splice_branch() Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org VFS handles updating ctime, so we don't need to update i_ctime in ext3_splace_branch(). I backport the following patch for ext3: http://marc.info/?l=linux-ext4&m=124505184027078&w=4 Signed-off-by: Kazuya Mio --- fs/ext3/inode.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/fs/ext3/inode.c b/fs/ext3/inode.c index 2d0afec..95cb0d1 100644 --- a/fs/ext3/inode.c +++ b/fs/ext3/inode.c @@ -795,10 +795,6 @@ static int ext3_splice_branch(handle_t *handle, struct inode *inode, } /* We are done with atomic stuff, now do the rest of housekeeping */ - - inode->i_ctime = CURRENT_TIME_SEC; - ext3_mark_inode_dirty(handle, inode); - /* ext3_mark_inode_dirty already updated i_sync_tid */ atomic_set(&ei->i_datasync_tid, handle->h_transaction->t_tid); /* had we spliced it onto indirect block? */ @@ -819,9 +815,9 @@ static int ext3_splice_branch(handle_t *handle, struct inode *inode, } else { /* * OK, we spliced it into the inode itself on a direct block. - * Inode was dirtied above. */ jbd_debug(5, "splicing direct\n"); + ext3_mark_inode_dirty(handle, inode); } return err;