From patchwork Sat Dec 13 19:21:16 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ilpo_J=C3=A4rvinen?= X-Patchwork-Id: 13850 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 66C9BDDFDD for ; Sun, 14 Dec 2008 06:21:57 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752082AbYLMTVl (ORCPT ); Sat, 13 Dec 2008 14:21:41 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752103AbYLMTVh (ORCPT ); Sat, 13 Dec 2008 14:21:37 -0500 Received: from courier.cs.helsinki.fi ([128.214.9.1]:49496 "EHLO mail.cs.helsinki.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751771AbYLMTVY (ORCPT ); Sat, 13 Dec 2008 14:21:24 -0500 Received: from wrl-59.cs.helsinki.fi (wrl-59.cs.helsinki.fi [128.214.166.179]) (AUTH: PLAIN cs-relay, TLS: TLSv1/SSLv3,256bits,AES256-SHA) by mail.cs.helsinki.fi with esmtp; Sat, 13 Dec 2008 21:21:22 +0200 id 0008C298.49440B32.00007B82 Received: by wrl-59.cs.helsinki.fi (Postfix, from userid 50795) id 9E5BCA00A9; Sat, 13 Dec 2008 21:21:22 +0200 (EET) From: "=?ISO-8859-1?Q?Ilpo_J=E4rvinen?=" To: David Miller Cc: netdev@vger.kernel.org, "=?utf-8?q?Ilpo=20J=E4rvinen?=" Subject: [PATCH 05/11] xfrm: join error paths Date: Sat, 13 Dec 2008 21:21:16 +0200 Message-Id: <1229196082-4162-6-git-send-email-ilpo.jarvinen@helsinki.fi> X-Mailer: git-send-email 1.5.4.2.156.ge3c5 In-Reply-To: <1229196082-4162-5-git-send-email-ilpo.jarvinen@helsinki.fi> References: <1229196082-4162-1-git-send-email-ilpo.jarvinen@helsinki.fi> <1229196082-4162-2-git-send-email-ilpo.jarvinen@helsinki.fi> <1229196082-4162-3-git-send-email-ilpo.jarvinen@helsinki.fi> <1229196082-4162-4-git-send-email-ilpo.jarvinen@helsinki.fi> <1229196082-4162-5-git-send-email-ilpo.jarvinen@helsinki.fi> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Signed-off-by: Ilpo Järvinen --- net/xfrm/xfrm_user.c | 22 ++++++++++++---------- 1 files changed, 12 insertions(+), 10 deletions(-) diff --git a/net/xfrm/xfrm_user.c b/net/xfrm/xfrm_user.c index 38ffaf3..b95a2d6 100644 --- a/net/xfrm/xfrm_user.c +++ b/net/xfrm/xfrm_user.c @@ -1688,21 +1688,16 @@ static int xfrm_add_acquire(struct sk_buff *skb, struct nlmsghdr *nlh, int err = -ENOMEM; if (!x) - return err; + goto nomem; err = verify_newpolicy_info(&ua->policy); - if (err) { - printk("BAD policy passed\n"); - kfree(x); - return err; - } + if (err) + goto bad_policy; /* build an XP */ xp = xfrm_policy_construct(net, &ua->policy, attrs, &err); - if (!xp) { - kfree(x); - return err; - } + if (!xp) + goto free_state; memcpy(&x->id, &ua->id, sizeof(ua->id)); memcpy(&x->props.saddr, &ua->saddr, sizeof(ua->saddr)); @@ -1727,6 +1722,13 @@ static int xfrm_add_acquire(struct sk_buff *skb, struct nlmsghdr *nlh, kfree(xp); return 0; + +bad_policy: + printk("BAD policy passed\n"); +free_state: + kfree(x); +nomem: + return err; } #ifdef CONFIG_XFRM_MIGRATE