diff mbox

[U-Boot,V4,5/7] README: Add description of SPI Flash (SF) command configuration

Message ID 1327863595-1524-6-git-send-email-eric.nelson@boundarydevices.com
State Accepted
Commit f61ec45eb5ad819520396f91385ef3855059c1dd
Headers show

Commit Message

Eric Nelson Jan. 29, 2012, 6:59 p.m. UTC
---
 README |   20 ++++++++++++++++++++
 1 files changed, 20 insertions(+), 0 deletions(-)

Comments

Marek Vasut Jan. 29, 2012, 7:17 p.m. UTC | #1
> ---
>  README |   20 ++++++++++++++++++++
>  1 files changed, 20 insertions(+), 0 deletions(-)
> 
> diff --git a/README b/README
> index f6ab85c..1a98915 100644
> --- a/README
> +++ b/README
> @@ -800,6 +800,7 @@ The following options need to be configured:
>  					  (requires CONFIG_CMD_I2C)
>  		CONFIG_CMD_SETGETDCR	  Support for DCR Register access
>  					  (4xx only)
> +		CONFIG_CMD_SF		* Read/write/erase SPI NOR flash

Why did you add the asterisk here ?

>  		CONFIG_CMD_SHA1SUM	  print sha1 memory digest
>  					  (requires CONFIG_CMD_MEMORY)
>  		CONFIG_CMD_SOURCE	  "source" command Support
> @@ -2179,6 +2180,25 @@ The following options need to be configured:
>  		allows to read/write in Dataflash via the standard
>  		commands cp, md...
> 
> +- Serial Flash support
> +		CONFIG_CMD_SF
> +
> +		Defining this option enables SPI flash commands
> +		'sf probe/read/write/erase/update'.
> +
> +		Usage requires an initial 'probe' to define the serial
> +		flash parameters, followed by read/write/erase/update
> +		commands.
> +
> +		The following defaults may be provided by the platform
> +		to handle the common case when only a single serial
> +		flash is present on the system.
> +
> +		CONFIG_SF_DEFAULT_BUS		Bus identifier
> +		CONFIG_SF_DEFAULT_CS		Chip-select
> +		CONFIG_SF_DEFAULT_MODE 		(see include/spi.h)
> +		CONFIG_SF_DEFAULT_SPEED		in Hz
> +
>  - SystemACE Support:
>  		CONFIG_SYSTEMACE
Eric Nelson Jan. 29, 2012, 7:57 p.m. UTC | #2
On 01/29/2012 12:17 PM, Marek Vasut wrote:
>> ---
>>   README |   20 ++++++++++++++++++++
>>   1 files changed, 20 insertions(+), 0 deletions(-)
>>
>> diff --git a/README b/README
>> index f6ab85c..1a98915 100644
>> --- a/README
>> +++ b/README
>> @@ -800,6 +800,7 @@ The following options need to be configured:
>>   					  (requires CONFIG_CMD_I2C)
>>   		CONFIG_CMD_SETGETDCR	  Support for DCR Register access
>>   					  (4xx only)
>> +		CONFIG_CMD_SF		* Read/write/erase SPI NOR flash
>
> Why did you add the asterisk here ?
>
Because CONFIG_CMD_SF isn't included in the default build.

	http://git.denx.de/cgi-bin/gitweb.cgi?p=u-boot.git;a=blob;f=README;h=9d713e8f4398b9af70844ab7910c67e400817bf6;hb=HEAD#l740
Mike Frysinger Jan. 30, 2012, 5:11 a.m. UTC | #3
On Sunday 29 January 2012 14:17:50 Marek Vasut wrote:
> > --- a/README
> > +++ b/README
> > 
> > +		CONFIG_CMD_SF		* Read/write/erase SPI NOR flash
> 
> Why did you add the asterisk here ?

from the README:
        The default command configuration includes all commands
        except those marked below with a "*".
-mike
Mike Frysinger Jan. 30, 2012, 5:12 a.m. UTC | #4
this patch is missing your s-o-b tag ...

otherwise, looks good.  thanks!
-mike
diff mbox

Patch

diff --git a/README b/README
index f6ab85c..1a98915 100644
--- a/README
+++ b/README
@@ -800,6 +800,7 @@  The following options need to be configured:
 					  (requires CONFIG_CMD_I2C)
 		CONFIG_CMD_SETGETDCR	  Support for DCR Register access
 					  (4xx only)
+		CONFIG_CMD_SF		* Read/write/erase SPI NOR flash
 		CONFIG_CMD_SHA1SUM	  print sha1 memory digest
 					  (requires CONFIG_CMD_MEMORY)
 		CONFIG_CMD_SOURCE	  "source" command Support
@@ -2179,6 +2180,25 @@  The following options need to be configured:
 		allows to read/write in Dataflash via the standard
 		commands cp, md...
 
+- Serial Flash support
+		CONFIG_CMD_SF
+
+		Defining this option enables SPI flash commands
+		'sf probe/read/write/erase/update'.
+
+		Usage requires an initial 'probe' to define the serial
+		flash parameters, followed by read/write/erase/update
+		commands.
+
+		The following defaults may be provided by the platform
+		to handle the common case when only a single serial
+		flash is present on the system.
+
+		CONFIG_SF_DEFAULT_BUS		Bus identifier
+		CONFIG_SF_DEFAULT_CS		Chip-select
+		CONFIG_SF_DEFAULT_MODE 		(see include/spi.h)
+		CONFIG_SF_DEFAULT_SPEED		in Hz
+
 - SystemACE Support:
 		CONFIG_SYSTEMACE