From patchwork Fri Jan 27 21:27:37 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Berger X-Patchwork-Id: 138334 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id E6E5FB6F9C for ; Sat, 28 Jan 2012 08:28:30 +1100 (EST) Received: from localhost ([::1]:35297 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RqtLL-0001dH-As for incoming@patchwork.ozlabs.org; Fri, 27 Jan 2012 16:28:23 -0500 Received: from eggs.gnu.org ([140.186.70.92]:50464) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RqtLD-0001cz-QQ for qemu-devel@nongnu.org; Fri, 27 Jan 2012 16:28:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RqtLB-0007mN-Iw for qemu-devel@nongnu.org; Fri, 27 Jan 2012 16:28:15 -0500 Received: from e2.ny.us.ibm.com ([32.97.182.142]:59936) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RqtLB-0007m7-FC for qemu-devel@nongnu.org; Fri, 27 Jan 2012 16:28:13 -0500 Received: from /spool/local by e2.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 27 Jan 2012 16:28:08 -0500 Received: from d01dlp01.pok.ibm.com (9.56.224.56) by e2.ny.us.ibm.com (192.168.1.102) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 27 Jan 2012 16:27:43 -0500 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id 6F71538C8065 for ; Fri, 27 Jan 2012 16:27:42 -0500 (EST) Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q0RLRflv350926 for ; Fri, 27 Jan 2012 16:27:42 -0500 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q0RLRfYe027795 for ; Fri, 27 Jan 2012 14:27:41 -0700 Received: from [9.59.241.154] (d941e-10.watson.ibm.com [9.59.241.154]) by d03av04.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id q0RLRcru027335; Fri, 27 Jan 2012 14:27:39 -0700 Message-ID: <4F2316C9.70807@linux.vnet.ibm.com> Date: Fri, 27 Jan 2012 16:27:37 -0500 From: Stefan Berger User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.23) Gecko/20110928 Fedora/3.1.15-1.fc14 Lightning/1.0b3pre Thunderbird/3.1.15 MIME-Version: 1.0 To: qemu-devel , blauwirbel@gmail.com References: <4F2312D4.1050408@linux.vnet.ibm.com> In-Reply-To: <4F2312D4.1050408@linux.vnet.ibm.com> X-Content-Scanned: Fidelis XPS MAILER x-cbid: 12012721-5112-0000-0000-00000475B392 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 32.97.182.142 Subject: Re: [Qemu-devel] suspend/resume not working on tip due to 59abb06 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org On 01/27/2012 04:10 PM, Stefan Berger wrote: > After bisecting the following commit seems to be the culprit for the > suspend/resume problems that I am seeing with the current tip > (73093354418602a2ff5e43cb91a21b17fbf047d8). > > commit 59abb06198ee9471e29c970f294eae80c0b39be1 > Author: Blue Swirl > Date: Sun Jan 22 11:00:44 2012 +0000 > > Once I revert this patch on the tip everything works fine again... > > Stefan > > And this patch here gets it to work: } diff --git a/exec-obsolete.h b/exec-obsolete.h index 03cf35e..a673386 100644 --- a/exec-obsolete.h +++ b/exec-obsolete.h @@ -101,7 +101,7 @@ static inline void cpu_physical_memory_mask_dirty_range(ram_ end = start + length; mask = ~dirty_flags; p = ram_list.phys_dirty + (start >> TARGET_PAGE_BITS); - for (addr = start; addr <= end; addr += TARGET_PAGE_SIZE) { + for (addr = start; addr < end; addr += TARGET_PAGE_SIZE) { *p++ &= mask; }