| Submitter | Stefano Stabellini |
|---|---|
| Date | Jan. 27, 2012, 6:21 p.m. |
| Message ID | <1327688498-12362-2-git-send-email-stefano.stabellini@eu.citrix.com> |
| Download | mbox | patch |
| Permalink | /patch/138266/ |
| State | New |
| Headers | show |
Comments
On 01/27/2012 07:21 PM, Stefano Stabellini wrote: > rtc_clock is only used by the RTC emulator (mc146818rtc.c), however Xen > has its own RTC emulator in the hypervisor so we can disable it. > > Signed-off-by: Stefano Stabellini<stefano.stabellini@eu.citrix.com> > --- > xen-all.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/xen-all.c b/xen-all.c > index d1fc597..bf183f7 100644 > --- a/xen-all.c > +++ b/xen-all.c > @@ -513,6 +513,7 @@ void xen_vcpu_init(void) > qemu_register_reset(xen_reset_vcpu, first_cpu); > xen_reset_vcpu(first_cpu); > } > + qemu_clock_enable(rtc_clock, false); > } > > /* get the ioreq packets from share mem */ I explained why this is wrong. Paolo
On Fri, 27 Jan 2012, Paolo Bonzini wrote: > On 01/27/2012 07:21 PM, Stefano Stabellini wrote: > > rtc_clock is only used by the RTC emulator (mc146818rtc.c), however Xen > > has its own RTC emulator in the hypervisor so we can disable it. > > > > Signed-off-by: Stefano Stabellini<stefano.stabellini@eu.citrix.com> > > --- > > xen-all.c | 1 + > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > > diff --git a/xen-all.c b/xen-all.c > > index d1fc597..bf183f7 100644 > > --- a/xen-all.c > > +++ b/xen-all.c > > @@ -513,6 +513,7 @@ void xen_vcpu_init(void) > > qemu_register_reset(xen_reset_vcpu, first_cpu); > > xen_reset_vcpu(first_cpu); > > } > > + qemu_clock_enable(rtc_clock, false); > > } > > > > /* get the ioreq packets from share mem */ > > I explained why this is wrong. Thanks for reminding me, I lost your previous email as I wasn't CC'ed...
Patch
diff --git a/xen-all.c b/xen-all.c index d1fc597..bf183f7 100644 --- a/xen-all.c +++ b/xen-all.c @@ -513,6 +513,7 @@ void xen_vcpu_init(void) qemu_register_reset(xen_reset_vcpu, first_cpu); xen_reset_vcpu(first_cpu); } + qemu_clock_enable(rtc_clock, false); } /* get the ioreq packets from share mem */
rtc_clock is only used by the RTC emulator (mc146818rtc.c), however Xen has its own RTC emulator in the hypervisor so we can disable it. Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> --- xen-all.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)