Patchwork MAINTAINERS: Add a section for the host OS and a W32 maintainer

login
register
mail settings
Submitter Stefan Weil
Date Jan. 27, 2012, 5:53 p.m.
Message ID <1327686829-11791-1-git-send-email-sw@weilnetz.de>
Download mbox | patch
Permalink /patch/138262/
State Accepted
Headers show

Comments

Stefan Weil - Jan. 27, 2012, 5:53 p.m.
Up to now, there was no special section for the different
host operating systems used with QEMU.

scripts/get_maintainer.pl did not show a maintainer for
OS specific files and patches.

Therefore I added three hosts systems:

* POSIX for the majority of host systems which are supported.
  This includes BSD and Linux host systems.

* LINUX is a special case of POSIX needed for some Linux specific
  files and directories.

* W32, W64 for a well known family of closed source operating systems.

I also added myself as a maintainer for W32, W64.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
 MAINTAINERS |   20 ++++++++++++++++++++
 1 files changed, 20 insertions(+), 0 deletions(-)
Kevin Wolf - Jan. 31, 2012, 1:35 p.m.
Am 27.01.2012 18:53, schrieb Stefan Weil:
> Up to now, there was no special section for the different
> host operating systems used with QEMU.
> 
> scripts/get_maintainer.pl did not show a maintainer for
> OS specific files and patches.
> 
> Therefore I added three hosts systems:
> 
> * POSIX for the majority of host systems which are supported.
>   This includes BSD and Linux host systems.
> 
> * LINUX is a special case of POSIX needed for some Linux specific
>   files and directories.
> 
> * W32, W64 for a well known family of closed source operating systems.
> 
> I also added myself as a maintainer for W32, W64.
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>  MAINTAINERS |   20 ++++++++++++++++++++
>  1 files changed, 20 insertions(+), 0 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 73c0a10..882958e 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -161,6 +161,26 @@ S: Supported
>  F: xen-*
>  F: */xen*
>  
> +Hosts:
> +------
> +
> +LINUX
> +L: qemu-devel@nongnu.org
> +S: Maintained
> +F: linux-*
> +F: linux-headers/
> +
> +POSIX
> +L: qemu-devel@nongnu.org
> +S: Maintained
> +F: *posix*

How can these be "Maintained" without a maintainer?

Kevin
Peter Maydell - Jan. 31, 2012, 2:40 p.m.
On 31 January 2012 13:35, Kevin Wolf <kwolf@redhat.com> wrote:
> Am 27.01.2012 18:53, schrieb Stefan Weil:
>> +Hosts:
>> +------
>> +
>> +LINUX
>> +L: qemu-devel@nongnu.org
>> +S: Maintained
>> +F: linux-*
>> +F: linux-headers/
>> +
>> +POSIX
>> +L: qemu-devel@nongnu.org
>> +S: Maintained
>> +F: *posix*
>
> How can these be "Maintained" without a maintainer?

They're maintained in the sense that if you break it somebody
*will* fix it, probably with a faster turnaround than any
other host system. Certainly 'Odd Fixes' doesn't sound right.

-- PMM
Kevin Wolf - Jan. 31, 2012, 2:48 p.m.
Am 31.01.2012 15:40, schrieb Peter Maydell:
> On 31 January 2012 13:35, Kevin Wolf <kwolf@redhat.com> wrote:
>> Am 27.01.2012 18:53, schrieb Stefan Weil:
>>> +Hosts:
>>> +------
>>> +
>>> +LINUX
>>> +L: qemu-devel@nongnu.org
>>> +S: Maintained
>>> +F: linux-*
>>> +F: linux-headers/
>>> +
>>> +POSIX
>>> +L: qemu-devel@nongnu.org
>>> +S: Maintained
>>> +F: *posix*
>>
>> How can these be "Maintained" without a maintainer?
> 
> They're maintained in the sense that if you break it somebody
> *will* fix it, probably with a faster turnaround than any
> other host system. Certainly 'Odd Fixes' doesn't sound right.

I agree, adding a maintainer name (Anthony?) would be better.

Kevin
Stefan Weil - Jan. 31, 2012, 6:20 p.m.
Am 31.01.2012 15:48, schrieb Kevin Wolf:
> Am 31.01.2012 15:40, schrieb Peter Maydell:
>> On 31 January 2012 13:35, Kevin Wolf <kwolf@redhat.com> wrote:
>>> Am 27.01.2012 18:53, schrieb Stefan Weil:
>>>> +Hosts:
>>>> +------
>>>> +
>>>> +LINUX
>>>> +L: qemu-devel@nongnu.org
>>>> +S: Maintained
>>>> +F: linux-*
>>>> +F: linux-headers/
>>>> +
>>>> +POSIX
>>>> +L: qemu-devel@nongnu.org
>>>> +S: Maintained
>>>> +F: *posix*
>>>
>>> How can these be "Maintained" without a maintainer?
>>
>> They're maintained in the sense that if you break it somebody
>> *will* fix it, probably with a faster turnaround than any
>> other host system. Certainly 'Odd Fixes' doesn't sound right.
>
> I agree, adding a maintainer name (Anthony?) would be better.
>
> Kevin

I added LINUX and POSIX just to have a hook were a maintainer
and files / directories can be added (and to fill the host list with
more than an entry for w32 :-)). Of course BSD and other hosts
can also be added if needed.

There are some more entries for qemu-devel which use
M: qemu-devel@nongnu.org. I think L: qemu-devel@nongnu.org
would be more appropriate there, too.

Regards,
Stefan
Anthony Liguori - Feb. 1, 2012, 10:11 p.m.
On 01/27/2012 11:53 AM, Stefan Weil wrote:
> Up to now, there was no special section for the different
> host operating systems used with QEMU.
>
> scripts/get_maintainer.pl did not show a maintainer for
> OS specific files and patches.
>
> Therefore I added three hosts systems:
>
> * POSIX for the majority of host systems which are supported.
>    This includes BSD and Linux host systems.
>
> * LINUX is a special case of POSIX needed for some Linux specific
>    files and directories.
>
> * W32, W64 for a well known family of closed source operating systems.
>
> I also added myself as a maintainer for W32, W64.
>
> Signed-off-by: Stefan Weil<sw@weilnetz.de>

Applied.  Thanks.

Regards,

Anthony Liguori

> ---
>   MAINTAINERS |   20 ++++++++++++++++++++
>   1 files changed, 20 insertions(+), 0 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 73c0a10..882958e 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -161,6 +161,26 @@ S: Supported
>   F: xen-*
>   F: */xen*
>
> +Hosts:
> +------
> +
> +LINUX
> +L: qemu-devel@nongnu.org
> +S: Maintained
> +F: linux-*
> +F: linux-headers/
> +
> +POSIX
> +L: qemu-devel@nongnu.org
> +S: Maintained
> +F: *posix*
> +
> +W32, W64
> +L: qemu-devel@nongnu.org
> +M: Stefan Weil<sw@weilnetz.de>
> +S: Maintained
> +F: *win32*
> +
>   ARM Machines
>   ------------
>   Gumstix

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 73c0a10..882958e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -161,6 +161,26 @@  S: Supported
 F: xen-*
 F: */xen*
 
+Hosts:
+------
+
+LINUX
+L: qemu-devel@nongnu.org
+S: Maintained
+F: linux-*
+F: linux-headers/
+
+POSIX
+L: qemu-devel@nongnu.org
+S: Maintained
+F: *posix*
+
+W32, W64
+L: qemu-devel@nongnu.org
+M: Stefan Weil <sw@weilnetz.de>
+S: Maintained
+F: *win32*
+
 ARM Machines
 ------------
 Gumstix