diff mbox

[v2,kernel,3.2.1] RTNETLINK adjusting values of min_ifinfo_dump_size

Message ID 3280801.2791327611666778.JavaMail.root@5-MeO-DMT.ynet.sk
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Štefan Gula Jan. 26, 2012, 9:01 p.m. UTC
From: Stefan Gula <steweg@gmail.com>

Setting link parameters on a netdevice changes the value
of if_nlmsg_size(), therefore it is necessary to recalculate
min_ifinfo_dump_size.

Signed-off-by: Stefan Gula <steweg@gmail.com>

---
V2-changelog: adjusted commit message

the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

David Miller Jan. 26, 2012, 9:37 p.m. UTC | #1
From: Stefan Gula <steweg@ynet.sk>
Date: Thu, 26 Jan 2012 22:01:06 +0100 (CET)

> From: Stefan Gula <steweg@gmail.com>
> 
> Setting link parameters on a netdevice changes the value
> of if_nlmsg_size(), therefore it is necessary to recalculate
> min_ifinfo_dump_size.
> 
> Signed-off-by: Stefan Gula <steweg@gmail.com>

Applied, but:

> +	min_ifinfo_dump_size = max_t(u16, if_nlmsg_size(dev),
> +					min_ifinfo_dump_size);
> +

The second line is not properly indented, the first non-space
character should line up with the first column after the
openning parenthesis on the previous line.

I fixed this up, but really this was a lot of tooth pulling to
get you to post this patch correctly.  You cannot consume this
much maintainer and reviewer resources in the future.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

--- linux-3.2.1-orig/net/core/rtnetlink.c	2012-01-12 20:42:45.000000000 +0100
+++ linux/net/core/rtnetlink.c	2012-01-24 14:26:58.083219352 +0100
@@ -1506,6 +1506,9 @@  errout:
 
 	if (send_addr_notify)
 		call_netdevice_notifiers(NETDEV_CHANGEADDR, dev);
+	min_ifinfo_dump_size = max_t(u16, if_nlmsg_size(dev),
+					min_ifinfo_dump_size);
+
 	return err;
 }
--
To unsubscribe from this list: send the line "unsubscribe netdev" in