Patchwork ext4: using PTR_ERR() on the wrong variable in ext4_ext_migrate()

login
register
mail settings
Submitter Dan Carpenter
Date Jan. 26, 2012, 6:14 a.m.
Message ID <20120126061406.GB15856@elgon.mountain>
Download mbox | patch
Permalink /patch/137880/
State Accepted
Headers show

Comments

Dan Carpenter - Jan. 26, 2012, 6:14 a.m.
"inode" is a valid pointer here.  "tmp_inode" was intended.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Theodore Ts'o - Feb. 13, 2012, 11:41 p.m.
On Thu, Jan 26, 2012 at 09:14:06AM +0300, Dan Carpenter wrote:
> "inode" is a valid pointer here.  "tmp_inode" was intended.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Thanks, applied.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/fs/ext4/migrate.c b/fs/ext4/migrate.c
index e7d6bb0..f39f80f 100644
--- a/fs/ext4/migrate.c
+++ b/fs/ext4/migrate.c
@@ -471,7 +471,7 @@  int ext4_ext_migrate(struct inode *inode)
 	tmp_inode = ext4_new_inode(handle, inode->i_sb->s_root->d_inode,
 				   S_IFREG, NULL, goal, owner);
 	if (IS_ERR(tmp_inode)) {
-		retval = PTR_ERR(inode);
+		retval = PTR_ERR(tmp_inode);
 		ext4_journal_stop(handle);
 		return retval;
 	}