From patchwork Wed Jan 25 17:27:35 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Graf X-Patchwork-Id: 137802 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 0734AB6F9A for ; Thu, 26 Jan 2012 04:28:43 +1100 (EST) Received: from localhost ([::1]:53624 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rq6eE-0004H5-CK for incoming@patchwork.ozlabs.org; Wed, 25 Jan 2012 12:28:38 -0500 Received: from eggs.gnu.org ([140.186.70.92]:48263) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rq6dt-0004F0-BJ for qemu-devel@nongnu.org; Wed, 25 Jan 2012 12:28:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rq6dJ-0002Au-Fo for qemu-devel@nongnu.org; Wed, 25 Jan 2012 12:28:17 -0500 Received: from cantor2.suse.de ([195.135.220.15]:48703 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rq6dJ-0002AT-61; Wed, 25 Jan 2012 12:27:41 -0500 Received: from relay2.suse.de (unknown [195.135.220.254]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id 26C6E915A2; Wed, 25 Jan 2012 18:27:39 +0100 (CET) From: Alexander Graf To: qemu-ppc@nongnu.org Date: Wed, 25 Jan 2012 18:27:35 +0100 Message-Id: <1327512458-28550-8-git-send-email-agraf@suse.de> X-Mailer: git-send-email 1.7.3.4 In-Reply-To: <1327512458-28550-1-git-send-email-agraf@suse.de> References: <1327512458-28550-1-git-send-email-agraf@suse.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4-2.6 X-Received-From: 195.135.220.15 Cc: Scott Wood , blauwirbel@gmail.com, qemu-devel Developers Subject: [Qemu-devel] [PATCH 07/10] PPC: booke206: Check for min/max TLB entry size X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org When setting a TLB entry, we need to check if the TLB we're putting it in actually supports the given size. According to the 2.06 PowerPC ISA, a value that's out of range can either be redefined to something implementation dependent or we can raise an illegal opcode exception. We do the latter. Signed-off-by: Alexander Graf --- v1 -> v2: - fix min/max check - use mav 2.0 prepared code - raise exception on invalid page size v2 -> v3: - check before writing tlb --- target-ppc/op_helper.c | 11 +++++++++++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/target-ppc/op_helper.c b/target-ppc/op_helper.c index 6339c95..3b197f2 100644 --- a/target-ppc/op_helper.c +++ b/target-ppc/op_helper.c @@ -4228,6 +4228,7 @@ void helper_booke206_tlbwe(void) { uint32_t tlbncfg, tlbn; ppcmas_tlb_t *tlb; + uint32_t size_tlb, size_ps; switch (env->spr[SPR_BOOKE_MAS0] & MAS0_WQ_MASK) { case MAS0_WQ_ALWAYS: @@ -4259,6 +4260,16 @@ void helper_booke206_tlbwe(void) tlb = booke206_cur_tlb(env); + /* check that we support the targeted size */ + size_tlb = (env->spr[SPR_BOOKE_MAS1] & MAS1_TSIZE_MASK) >> MAS1_TSIZE_SHIFT; + size_ps = booke206_tlbnps(env, tlbn); + if ((env->spr[SPR_BOOKE_MAS1] & MAS1_VALID) && (tlbncfg & TLBnCFG_AVAIL) && + !(size_ps & (1 << size_tlb))) { + helper_raise_exception_err(POWERPC_EXCP_PROGRAM, + POWERPC_EXCP_INVAL | + POWERPC_EXCP_INVAL_INVAL); + } + if (msr_gs) { cpu_abort(env, "missing HV implementation\n"); }