From patchwork Wed Jan 25 14:11:04 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 137769 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id EFF09B6F62 for ; Thu, 26 Jan 2012 01:11:23 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1328105484; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Date: From:To:Subject:Message-ID:User-Agent:MIME-Version:Content-Type: Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:Sender:Delivered-To; bh=PCynDOq0AlHJemeZRt+a iqTGCno=; b=dgmVxw35feOuUDDX8KuJ0kdTNDcwZYexAq0PnY+xl8cIt015WJ7L DXcjjPVWHBD2pIAsOxmSysCy/cRY1dodkHGHqVLBIOg7jNlotFyYO1GUIcq3r2Xt 8v3Bp5y1UDCbU5CYz+TvlxHzieqJPWAgGEvibxK0XDVl0R2Yf0umMDA= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Date:From:To:Subject:Message-ID:User-Agent:MIME-Version:Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=DP1hX+0x7sCoXN9GE92uwY5dN8n/tROSorkUHyblLfpX+ERVuRQrbPDmifxyHR JCgY/opnZF+RdzCFm4wbs/Y3A3wO+D5wbTSVjNrTsKNsxvzMHgd7/Wr4FnOUACVY Sja4dC9MoETslVAIg/1P8l8klwzl7kZXDiDZB67aom0oI=; Received: (qmail 3931 invoked by alias); 25 Jan 2012 14:11:20 -0000 Received: (qmail 3922 invoked by uid 22791); 25 Jan 2012 14:11:18 -0000 X-SWARE-Spam-Status: No, hits=-5.7 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from cantor2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 25 Jan 2012 14:11:05 +0000 Received: from relay1.suse.de (unknown [195.135.220.254]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id A1D6A90B96 for ; Wed, 25 Jan 2012 15:11:04 +0100 (CET) Date: Wed, 25 Jan 2012 15:11:04 +0100 (CET) From: Richard Guenther To: gcc-patches@gcc.gnu.org Subject: [PATCH] Fix VN value-numbering with VIEW_CONVERT_EXPRs Message-ID: User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org VN ops comparison code value-numbers VIEW_CONVERT_EXPR(__thing_31).._M_node and __thing_31->_M_node the same because it fails to check for *__thing_31 vs. __thing_31. Bootstrap & regtest pending on x86_64. Richard. 2012-01-25 Richard Guenther * tree-ssa-sccvn.c (vn_reference_eq): Also compare if both bases are dereferenced. Index: gcc/tree-ssa-sccvn.c =================================================================== --- gcc/tree-ssa-sccvn.c (revision 183514) +++ gcc/tree-ssa-sccvn.c (working copy) @@ -556,6 +556,7 @@ vn_reference_eq (const void *p1, const v tem1.type = TREE_TYPE (tem1.op0); tem1.opcode = TREE_CODE (tem1.op0); vro1 = &tem1; + deref1 = false; } if (deref2 && vro2->opcode == ADDR_EXPR) { @@ -564,7 +565,10 @@ vn_reference_eq (const void *p1, const v tem2.type = TREE_TYPE (tem2.op0); tem2.opcode = TREE_CODE (tem2.op0); vro2 = &tem2; + deref2 = false; } + if (deref1 != deref2) + return false; if (!vn_reference_op_eq (vro1, vro2)) return false; ++j;