Patchwork [U-Boot,3/3] Armada100: gplugD: Add USB command support

login
register
mail settings
Submitter Ajay Bhargav
Date Jan. 25, 2012, 12:19 p.m.
Message ID <1327493993-19197-3-git-send-email-ajay.bhargav@einfochips.com>
Download mbox | patch
Permalink /patch/137748/
State Superseded
Delegated to: Marek Vasut
Headers show

Comments

Ajay Bhargav - Jan. 25, 2012, 12:19 p.m.
This patch adds support for USB commands and USB storage device for
Marvell gplugD

Signed-off-by: Ajay Bhargav <ajay.bhargav@einfochips.com>
---
 include/configs/gplugd.h |   17 +++++++++++++++++
 1 files changed, 17 insertions(+), 0 deletions(-)
Prafulla Wadaskar - Jan. 26, 2012, 6:05 p.m.
> -----Original Message-----
> From: Ajay Bhargav [mailto:ajay.bhargav@einfochips.com]
> Sent: 25 January 2012 17:50
> To: linux@bohmer.net
> Cc: Prafulla Wadaskar; marek.vasut@gmail.com; u-boot@lists.denx.de;
> Ajay Bhargav
> Subject: [PATCH 3/3] Armada100: gplugD: Add USB command support
> 
> This patch adds support for USB commands and USB storage device for
> Marvell gplugD
> 
> Signed-off-by: Ajay Bhargav <ajay.bhargav@einfochips.com>
> ---
>  include/configs/gplugd.h |   17 +++++++++++++++++
>  1 files changed, 17 insertions(+), 0 deletions(-)
> 
> diff --git a/include/configs/gplugd.h b/include/configs/gplugd.h
> index 9813309..f8dc74f 100644
> --- a/include/configs/gplugd.h
> +++ b/include/configs/gplugd.h
> @@ -134,4 +134,21 @@
>  #define CONFIG_CMD_EDITENV
>  #define CONFIG_CMD_SAVEENV
> 
> +#define CONFIG_CMD_USB

This line should be moved up where all the commands are defined (below config_cmd_default.h)

> +
> +#ifdef CONFIG_CMD_USB
> +#define CONFIG_USB_EHCI
> +#define CONFIG_USB_EHCI_ARMADA100
> +#define CONFIG_EHCI_IS_TDI
> +#define CONFIG_USB_STORAGE
> +
> +#ifndef CONFIG_DOS_PARTITION

Does this undef needed? remove it you can.

Regards..
Prafulla . . .
Ajay Bhargav - Jan. 27, 2012, 7:05 a.m.
----- "Prafulla Wadaskar" <prafulla@marvell.com> wrote:

> > -----Original Message-----
> > From: Ajay Bhargav [mailto:ajay.bhargav@einfochips.com]
> > Sent: 25 January 2012 17:50
> > To: linux@bohmer.net
> > Cc: Prafulla Wadaskar; marek.vasut@gmail.com; u-boot@lists.denx.de;
> > Ajay Bhargav
> > Subject: [PATCH 3/3] Armada100: gplugD: Add USB command support
> > 
> > This patch adds support for USB commands and USB storage device for
> > Marvell gplugD
[...snip...]
> > 
> > +#ifdef CONFIG_CMD_USB
> > +#define CONFIG_USB_EHCI
> > +#define CONFIG_USB_EHCI_ARMADA100
> > +#define CONFIG_EHCI_IS_TDI
> > +#define CONFIG_USB_STORAGE
> > +
> > +#ifndef CONFIG_DOS_PARTITION
> 
> Does this undef needed? remove it you can.
> 
> Regards..
> Prafulla . . .
> 

I will review it again and remove it if not needed.

Regards,
Ajay Bhargav

Patch

diff --git a/include/configs/gplugd.h b/include/configs/gplugd.h
index 9813309..f8dc74f 100644
--- a/include/configs/gplugd.h
+++ b/include/configs/gplugd.h
@@ -134,4 +134,21 @@ 
 #define CONFIG_CMD_EDITENV
 #define CONFIG_CMD_SAVEENV
 
+#define CONFIG_CMD_USB
+
+#ifdef CONFIG_CMD_USB
+#define CONFIG_USB_EHCI
+#define CONFIG_USB_EHCI_ARMADA100
+#define CONFIG_EHCI_IS_TDI
+#define CONFIG_USB_STORAGE
+
+#ifndef CONFIG_DOS_PARTITION
+#define CONFIG_DOS_PARTITION
+#endif /* CONFIG_DOS_PARTITION */
+
+#define CONFIG_ISO_PARTITION
+#define CONFIG_SUPPORT_VFAT
+#define CONFIG_CMD_EXT2
+#endif /* CONFIG_CMD_USB */
+
 #endif	/* __CONFIG_GPLUGD_H */