Patchwork git bisect results

login
register
mail settings
Submitter Erik Rull
Date Jan. 25, 2012, 11:48 a.m.
Message ID <0NmkTZ-1RuP3p2oYy-00DGmw@icpu819.kundenserver.de>
Download mbox | patch
Permalink /patch/137738/
State New
Headers show

Comments

Erik Rull - Jan. 25, 2012, 11:48 a.m.
Hi Jan,

This little change fixes my problem with the usb-tablet update rate.

Can you please verify if this has some side effects?

If not, can you post a real patch?
I don't know how to handle the whole patching and committing stuff exactly.

Thanks.

Erik
Jan Kiszka - Jan. 25, 2012, 2:19 p.m.
On 2012-01-25 12:48, erik.rull@rdsoftware.de wrote:
> Hi Jan,

You should CC me then... :)

> 
> This little change fixes my problem with the usb-tablet update rate.
> 
> Can you please verify if this has some side effects?

Surely as it disables in general valid code, namely the auto-grabbing
feature. You should notice the difference.

> 
> If not, can you post a real patch?
> I don't know how to handle the whole patching and committing stuff exactly.

We need to understand the problem first anyway, and as I cannot
reproduce it, I will need you help:

Can you instrument the code, e.g. with printf, to find out which of the
disabled branches is taken when, specifically how often? Can you also
check if values like max_x/max_y or the ev->motion content make sense
for your setup?

Thanks,
Jan
Erik Rull - Jan. 25, 2012, 9:13 p.m.
Jan Kiszka wrote:
> On 2012-01-25 12:48, erik.rull@rdsoftware.de wrote:
>> Hi Jan,
>
> You should CC me then... :)

I will do that for upcoming emails.

>>
>> This little change fixes my problem with the usb-tablet update rate.
>>
>> Can you please verify if this has some side effects?
>
> Surely as it disables in general valid code, namely the auto-grabbing
> feature. You should notice the difference.
>
>>
>> If not, can you post a real patch?
>> I don't know how to handle the whole patching and committing stuff exactly.
>
> We need to understand the problem first anyway, and as I cannot
> reproduce it, I will need you help:
>
> Can you instrument the code, e.g. with printf, to find out which of the
> disabled branches is taken when, specifically how often? Can you also
> check if values like max_x/max_y or the ev->motion content make sense
> for your setup?
>
> Thanks,
> Jan
>

Yes, I will add some counters and dump them in discrete timeslots to see 
what's the difference between the fullscreen and the windowed mode.

Maybe the removed code parts do not affect my main application where the 
window is resized to fullscreen. But for maintenance it is definitively 
windowed where I haven't had any problems with the grabbing / releasing up 
to now.

Best regards,

Erik

Patch

diff --git a/ui/sdl.c b/ui/sdl.c
index 8cafc44..ecd70db 100644
--- a/ui/sdl.c
+++ b/ui/sdl.c
@@ -769,7 +769,7 @@  static void handle_mousemotion(DisplayState *ds,
SDL_Event *ev)
 {
     int max_x, max_y;

-    if (is_graphic_console() &&
+/*    if (is_graphic_console() &&
         (kbd_mouse_is_absolute() || absolute_enabled)) {
         max_x = real_screen->w - 1;