From patchwork Tue Jan 24 19:50:52 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Sandiford X-Patchwork-Id: 137627 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 88647B6EE8 for ; Wed, 25 Jan 2012 06:51:13 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1328039473; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:From:To:Mail-Followup-To:Subject:Date:Message-ID: User-Agent:MIME-Version:Content-Type:Mailing-List:Precedence: List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=Gg3G3Dw4pgg89Y5XUHbJjKk2rqg=; b=ydSKC/WGPnFD9ag ci6GiVrnCkzHagFv33SEBTgxsO/W7BZttYotF+f2zTQfhdyjnWllb3UF+FgWK6T+ YvxDcR1ZyhehH9NpHUX48gAvps9KmLnk45JyDnywi7EKzAYCBtFkml7+/kW/hjlt a0HQz0aarwt6XBTiZjiXnyg2qQzU= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Received:From:To:Mail-Followup-To:Subject:Date:Message-ID:User-Agent:MIME-Version:Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=qgThHQ/5knUffQkXLpFqY1Btj0FjozgTvysWHG15hH2KSwM6u3Am6DMK0u2w81 +UJv9rco1EjDF1FltfBVgpEObFp8lQuIiPyU3hCx11UDEp0B6UzF48Z2BnkKTfpY nDUkQkMScRo8pP35v5htRpc7nOTkQ/7WaWYaYHkqjGoZo=; Received: (qmail 5064 invoked by alias); 24 Jan 2012 19:51:10 -0000 Received: (qmail 5052 invoked by uid 22791); 24 Jan 2012 19:51:09 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-wi0-f175.google.com (HELO mail-wi0-f175.google.com) (209.85.212.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 24 Jan 2012 19:50:56 +0000 Received: by wibhq7 with SMTP id hq7so646451wib.20 for ; Tue, 24 Jan 2012 11:50:55 -0800 (PST) Received: by 10.180.103.97 with SMTP id fv1mr23466951wib.17.1327434655117; Tue, 24 Jan 2012 11:50:55 -0800 (PST) Received: from localhost (rsandifo.gotadsl.co.uk. [82.133.89.107]) by mx.google.com with ESMTPS id fv6sm55683101wib.8.2012.01.24.11.50.53 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 24 Jan 2012 11:50:54 -0800 (PST) From: Richard Sandiford To: gcc-patches@gcc.gnu.org Mail-Followup-To: gcc-patches@gcc.gnu.org, rdsandiford@googlemail.com Subject: [committed] Avoid optabs.c warning Date: Tue, 24 Jan 2012 19:50:52 +0000 Message-ID: <87liow6fs3.fsf@firetop.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org If the target doesn't have an atomic_test_and_set pattern, we'd warn about "mode" being unused. Tested on mips64-linux-gnu and applied as obvious. Richard gcc/ * optabs.c (gen_atomic_test_and_set): Use each argument. Index: gcc/optabs.c =================================================================== --- gcc/optabs.c 2012-01-24 19:48:11.000000000 +0000 +++ gcc/optabs.c 2012-01-24 19:48:11.000000000 +0000 @@ -7311,7 +7311,8 @@ maybe_emit_compare_and_swap_exchange_loo #ifndef HAVE_atomic_test_and_set #define HAVE_atomic_test_and_set 0 #define CODE_FOR_atomic_test_and_set CODE_FOR_nothing -#define gen_atomic_test_and_set(x,y,z) (gcc_unreachable (), NULL_RTX) +#define gen_atomic_test_and_set(x,y,z) \ + (gcc_unreachable (), (void) (0 && (x) && (y) && (z)), NULL_RTX) #endif static rtx