Patchwork net: eliminate warning from NETIF_F_UFO on bridge

login
register
mail settings
Submitter stephen hemminger
Date Dec. 12, 2008, 6:27 p.m.
Message ID <20081212102708.3f8dfbff@extreme>
Download mbox | patch
Permalink /patch/13759/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

stephen hemminger - Dec. 12, 2008, 6:27 p.m.
The bridge device always causes a warning because when it is first created
it has the no checksum flag set along with all the segmentation/fragmentation
offload bits.  The code in register_netdevice incorrectly checks for only
hardware checksum bit and ignores no checksum bit.

Similar code is already in 2.6.28:
   commit b63365a2d60268a3988285d6c3c6003d7066f93a
   net: Fix disjunct computation of netdev features

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
---
Patch against 2.6.27.y

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

--- a/net/core/dev.c	2008-12-09 09:52:03.226334984 -0800
+++ b/net/core/dev.c	2008-12-09 09:53:15.527751814 -0800
@@ -3990,7 +3990,7 @@  int register_netdevice(struct net_device
 		dev->features &= ~NETIF_F_TSO;
 	}
 	if (dev->features & NETIF_F_UFO) {
-		if (!(dev->features & NETIF_F_HW_CSUM)) {
+		if (!(dev->features & NETIF_F_GEN_CSUM)) {
 			printk(KERN_ERR "%s: Dropping NETIF_F_UFO since no "
 					"NETIF_F_HW_CSUM feature.\n",
 							dev->name);