Patchwork [build] Cleanup rs6000/t-ppccomm configurations (PR other/51022)

login
register
mail settings
Submitter Alan Modra
Date Jan. 24, 2012, 11:20 a.m.
Message ID <20120124112012.GC5903@bubble.grove.modra.org>
Download mbox | patch
Permalink /patch/137538/
State New
Headers show

Comments

Alan Modra - Jan. 24, 2012, 11:20 a.m.
On Mon, Dec 05, 2011 at 07:25:35PM -0500, David Edelsohn wrote:
> Is this fixed or is someone writing a follow-up patch?

This does the trick.  You could also use
	case ${host}:${with_multisubdir} in
	    *:*32*)
		;;
	    powerpc64-*:* | *:*64*)
		tmake_file="$tmake_file rs6000/t-linux64"
		;;
	esac
in config.host, but that's unnecessarily complicated.  The t-linux64
bits can safely go in other config files.  Bootstrapped and regression
tested powerpc-linux and powerpc64-linux.

	* config/rs6000/t-linux64: Delete.  Move..
	* config/rs6000/t-ppc64-fp: .. softfp_wrap defines to here..
	* config/rs6000/t-linux: ..and libgcc flags to here.
Paolo Bonzini - Jan. 24, 2012, 11:23 a.m.
On 01/24/2012 12:20 PM, Alan Modra wrote:
> On Mon, Dec 05, 2011 at 07:25:35PM -0500, David Edelsohn wrote:
>> Is this fixed or is someone writing a follow-up patch?
>
> This does the trick.  You could also use
> 	case ${host}:${with_multisubdir} in
> 	    *:*32*)
> 		;;
> 	    powerpc64-*:* | *:*64*)
> 		tmake_file="$tmake_file rs6000/t-linux64"
> 		;;
> 	esac
> in config.host, but that's unnecessarily complicated.  The t-linux64
> bits can safely go in other config files.  Bootstrapped and regression
> tested powerpc-linux and powerpc64-linux.

Ok.

Paolo
Rainer Orth - Jan. 24, 2012, 11:40 a.m.
Alan Modra <amodra@gmail.com> writes:

> On Mon, Dec 05, 2011 at 07:25:35PM -0500, David Edelsohn wrote:
>> Is this fixed or is someone writing a follow-up patch?
>
> This does the trick.  You could also use
> 	case ${host}:${with_multisubdir} in
> 	    *:*32*)
> 		;;
> 	    powerpc64-*:* | *:*64*)
> 		tmake_file="$tmake_file rs6000/t-linux64"
> 		;;
> 	esac
> in config.host, but that's unnecessarily complicated.  The t-linux64
> bits can safely go in other config files.  Bootstrapped and regression
> tested powerpc-linux and powerpc64-linux.

Thanks for doing this.  I still meant to get back to this, but didn't
have much time for GCC work lately.

	Rainer
David Edelsohn - Jan. 24, 2012, 3:16 p.m.
On Tue, Jan 24, 2012 at 6:20 AM, Alan Modra <amodra@gmail.com> wrote:
> On Mon, Dec 05, 2011 at 07:25:35PM -0500, David Edelsohn wrote:
>> Is this fixed or is someone writing a follow-up patch?
>
> This does the trick.  You could also use
>        case ${host}:${with_multisubdir} in
>            *:*32*)
>                ;;
>            powerpc64-*:* | *:*64*)
>                tmake_file="$tmake_file rs6000/t-linux64"
>                ;;
>        esac
> in config.host, but that's unnecessarily complicated.  The t-linux64
> bits can safely go in other config files.  Bootstrapped and regression
> tested powerpc-linux and powerpc64-linux.
>
>        * config/rs6000/t-linux64: Delete.  Move..
>        * config/rs6000/t-ppc64-fp: .. softfp_wrap defines to here..
>        * config/rs6000/t-linux: ..and libgcc flags to here.

Okay.

Thanks, David

Patch

Index: libgcc/config/rs6000/t-linux64
===================================================================
--- libgcc/config/rs6000/t-linux64	(revision 183464)
+++ libgcc/config/rs6000/t-linux64	(working copy)
@@ -1,4 +0,0 @@ 
-HOST_LIBGCC2_CFLAGS += -mno-minimal-toc
-
-softfp_wrap_start := '\#ifndef __powerpc64__'
-softfp_wrap_end := '\#endif'
Index: libgcc/config/rs6000/t-ppc64-fp
===================================================================
--- libgcc/config/rs6000/t-ppc64-fp	(revision 183464)
+++ libgcc/config/rs6000/t-ppc64-fp	(working copy)
@@ -1,2 +1,5 @@ 
 # Can be used unconditionally, wrapped in __powerpc64__ || __64BIT__ __ppc64__.
 LIB2ADD += $(srcdir)/config/rs6000/ppc64-fp.c
+
+softfp_wrap_start := '\#ifndef __powerpc64__'
+softfp_wrap_end := '\#endif'
Index: libgcc/config/rs6000/t-linux
===================================================================
--- libgcc/config/rs6000/t-linux	(revision 183464)
+++ libgcc/config/rs6000/t-linux	(working copy)
@@ -1,3 +1,3 @@ 
 SHLIB_MAPFILES += $(srcdir)/config/rs6000/libgcc-glibc.ver
 
-HOST_LIBGCC2_CFLAGS += -mlong-double-128
+HOST_LIBGCC2_CFLAGS += -mlong-double-128 -mno-minimal-toc