From patchwork Fri Dec 12 15:00:14 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Schwab X-Patchwork-Id: 13747 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from ozlabs.org (localhost [127.0.0.1]) by ozlabs.org (Postfix) with ESMTP id 064854763C for ; Sat, 13 Dec 2008 02:00:41 +1100 (EST) X-Original-To: linuxppc-dev@ozlabs.org Delivered-To: linuxppc-dev@ozlabs.org Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx2.suse.de", Issuer "CAcert Class 3 Root" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id AECB7DE027 for ; Sat, 13 Dec 2008 02:00:21 +1100 (EST) Received: from Relay1.suse.de (relay-ext.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id 0FE9C4700A; Fri, 12 Dec 2008 16:00:17 +0100 (CET) From: Andreas Schwab To: Johannes Berg Subject: Re: powerbook VT garbled between rc7 and rc8 References: <1229078554.3600.8.camel@johannes.berg> <1229092999.3600.10.camel@johannes.berg> X-Yow: NANCY!! Why is everything RED?! Date: Fri, 12 Dec 2008 16:00:14 +0100 In-Reply-To: <1229092999.3600.10.camel@johannes.berg> (Johannes Berg's message of "Fri, 12 Dec 2008 15:43:19 +0100") Message-ID: User-Agent: Gnus/5.110009 (No Gnus v0.9) Emacs/22.3 (gnu/linux) MIME-Version: 1.0 Cc: linuxppc-dev list X-BeenThere: linuxppc-dev@ozlabs.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org Johannes Berg writes: > On Fri, 2008-12-12 at 13:05 +0100, Andreas Schwab wrote: >> Johannes Berg writes: >> >> > After upgrading to -rc8 yesterday my powerbook started up today with the >> > screen totally garbled, only occasionally was a word readable. >> >> Try 6c34bc2976b30dc8b56392c020e25bae1f363cab (Revert "radeonfb: >> accelerate imageblit and other improvements"). > > That's post -rc8, ok, but -rc7 worked fine here, and the stuff it > reverts is all pre -rc7, no? Strange. I'll try later. This appears to be a side effect of setting up info->pixmap in radeon_set_fbinfo even if accel_cexp is 0. Alternatively to the cited patch you can also use something like this: Andreas. diff --git a/drivers/video/aty/radeon_base.c b/drivers/video/aty/radeon_base.c index d5b27f9..532e2c5 100644 --- a/drivers/video/aty/radeon_base.c +++ b/drivers/video/aty/radeon_base.c @@ -1895,6 +1895,9 @@ static int __devinit radeon_set_fbinfo (struct radeonfb_info *rinfo) /* Allocate colormap */ fb_alloc_cmap(&info->cmap, 256, 0); + if (!accel_cexp) + goto bail; + /* Setup pixmap used for acceleration */ #define PIXMAP_SIZE (2048 * 4)