Patchwork powerbook VT garbled between rc7 and rc8

login
register
mail settings
Submitter Andreas Schwab
Date Dec. 12, 2008, 3 p.m.
Message ID <jeprjxphfl.fsf@sykes.suse.de>
Download mbox | patch
Permalink /patch/13747/
State Not Applicable
Headers show

Comments

Andreas Schwab - Dec. 12, 2008, 3 p.m.
Johannes Berg <johannes@sipsolutions.net> writes:

> On Fri, 2008-12-12 at 13:05 +0100, Andreas Schwab wrote:
>> Johannes Berg <johannes@sipsolutions.net> writes:
>> 
>> > After upgrading to -rc8 yesterday my powerbook started up today with the
>> > screen totally garbled, only occasionally was a word readable.
>> 
>> Try 6c34bc2976b30dc8b56392c020e25bae1f363cab (Revert "radeonfb:
>> accelerate imageblit and other improvements").
>
> That's post -rc8, ok, but -rc7 worked fine here, and the stuff it
> reverts is all pre -rc7, no? Strange. I'll try later.

This appears to be a side effect of setting up info->pixmap in
radeon_set_fbinfo even if accel_cexp is 0.  Alternatively to the cited
patch you can also use something like this:


Andreas.
Benjamin Herrenschmidt - Dec. 12, 2008, 7:36 p.m.
On Fri, 2008-12-12 at 16:00 +0100, Andreas Schwab wrote:
> Johannes Berg <johannes@sipsolutions.net> writes:
> 
> > On Fri, 2008-12-12 at 13:05 +0100, Andreas Schwab wrote:
> >> Johannes Berg <johannes@sipsolutions.net> writes:
> >> 
> >> > After upgrading to -rc8 yesterday my powerbook started up today with the
> >> > screen totally garbled, only occasionally was a word readable.
> >> 
> >> Try 6c34bc2976b30dc8b56392c020e25bae1f363cab (Revert "radeonfb:
> >> accelerate imageblit and other improvements").
> >
> > That's post -rc8, ok, but -rc7 worked fine here, and the stuff it
> > reverts is all pre -rc7, no? Strange. I'll try later.
> 
> This appears to be a side effect of setting up info->pixmap in
> radeon_set_fbinfo even if accel_cexp is 0.  Alternatively to the cited
> patch you can also use something like this:

Right but Linus just reverted the whole thing. Which is probably the way
to go. I'll try to fix the fbdev core itself one of these days, it's
seriously broken vs. handling of pitch in images.

Ben.

> diff --git a/drivers/video/aty/radeon_base.c b/drivers/video/aty/radeon_base.c
> index d5b27f9..532e2c5 100644
> --- a/drivers/video/aty/radeon_base.c
> +++ b/drivers/video/aty/radeon_base.c
> @@ -1895,6 +1895,9 @@ static int __devinit radeon_set_fbinfo (struct radeonfb_info *rinfo)
>  	/* Allocate colormap */
>  	fb_alloc_cmap(&info->cmap, 256, 0);
>  
> +	if (!accel_cexp)
> +		goto bail;
> +
>  	/* Setup pixmap used for acceleration */
>  #define PIXMAP_SIZE	(2048 * 4)
>  
> 
> Andreas.
>

Patch

diff --git a/drivers/video/aty/radeon_base.c b/drivers/video/aty/radeon_base.c
index d5b27f9..532e2c5 100644
--- a/drivers/video/aty/radeon_base.c
+++ b/drivers/video/aty/radeon_base.c
@@ -1895,6 +1895,9 @@  static int __devinit radeon_set_fbinfo (struct radeonfb_info *rinfo)
 	/* Allocate colormap */
 	fb_alloc_cmap(&info->cmap, 256, 0);
 
+	if (!accel_cexp)
+		goto bail;
+
 	/* Setup pixmap used for acceleration */
 #define PIXMAP_SIZE	(2048 * 4)