Patchwork [v3] Don't XFAIL 22_locale/num_put/put/*char/14220.cc on 32-bit Solaris 10/x86

login
register
mail settings
Submitter Rainer Orth
Date Jan. 23, 2012, 5:50 p.m.
Message ID <yddaa5epau5.fsf@manam.CeBiTec.Uni-Bielefeld.DE>
Download mbox | patch
Permalink /patch/137444/
State New
Headers show

Comments

Rainer Orth - Jan. 23, 2012, 5:50 p.m.
I'm currently seeing two XPASSes in 32-bit Solaris 10/x86 libstdc++
testresults:

XPASS: 22_locale/num_put/put/char/14220.cc execution test
XPASS: 22_locale/num_put/put/wchar_t/14220.cc execution test

It turned out that the libc bug which caused those tests to be xfailed
has been fixed in Solaris 10 Update 10, so I'm removing the xfail to
accomodate this.

Tested with the appropriate runtest invocations on i386-pc-solaris2.10
and i386-pc-solaris2.9, installed on mainline.

	Rainer


2012-01-23  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

	* testsuite/22_locale/num_put/put/char/14220.cc: Don't xfail on
	32-bit Solaris 10/x86.
	* testsuite/22_locale/num_put/put/wchar_t/14220.cc: Likewise.

Patch

# HG changeset patch
# Parent 7c02309d42d500d0d71db21c174ca4880f38f6b8
Don't XFAIL 22_locale/num_put/put/*char/14220.cc on 32-bit Solaris 10/x86

diff --git a/libstdc++-v3/testsuite/22_locale/num_put/put/char/14220.cc b/libstdc++-v3/testsuite/22_locale/num_put/put/char/14220.cc
--- a/libstdc++-v3/testsuite/22_locale/num_put/put/char/14220.cc
+++ b/libstdc++-v3/testsuite/22_locale/num_put/put/char/14220.cc
@@ -1,6 +1,6 @@ 
 // 2004-04-30  Paolo Carlini  <pcarlini@suse.de>
 
-// Copyright (C) 2004, 2009, 2010, 2011 Free Software Foundation
+// Copyright (C) 2004, 2009, 2010, 2011, 2012 Free Software Foundation
 //
 // This file is part of the GNU ISO C++ Library.  This library is free
 // software; you can redistribute it and/or modify it under the
@@ -19,12 +19,11 @@ 
 
 // 22.2.2.2.1  num_put members
 
-// On Solaris 9/x86 and 32-bit Solaris 10/x86, this test crashes in libc.
-// Inside libstdc++, we call sprintf like so:
+// On Solaris 9/x86 and 32-bit Solaris 10/x86 before update 10, this test
+// crashes in libc.  Inside libstdc++, we call sprintf like so:
 //   sprintf (buffer, "%.*f", 1000, 1.0)
 // which crashes.
 // { dg-xfail-run-if "" i?86-*-solaris2.9 }
-// { dg-xfail-run-if "" { i?86-*-solaris2.10 && ilp32 } }
 
 #include <locale>
 #include <sstream>
diff --git a/libstdc++-v3/testsuite/22_locale/num_put/put/wchar_t/14220.cc b/libstdc++-v3/testsuite/22_locale/num_put/put/wchar_t/14220.cc
--- a/libstdc++-v3/testsuite/22_locale/num_put/put/wchar_t/14220.cc
+++ b/libstdc++-v3/testsuite/22_locale/num_put/put/wchar_t/14220.cc
@@ -1,6 +1,6 @@ 
 // 2004-04-30  Paolo Carlini  <pcarlini@suse.de>
 
-// Copyright (C) 2004, 2009, 2010 Free Software Foundation
+// Copyright (C) 2004, 2009, 2010, 2012 Free Software Foundation
 //
 // This file is part of the GNU ISO C++ Library.  This library is free
 // software; you can redistribute it and/or modify it under the
@@ -23,11 +23,11 @@ 
 #include <sstream>
 #include <testsuite_hooks.h>
 
-// On Solaris 9 and 32-bit Solaris 10/x86, this test crashes in libc.  Inside
-// libstdc++, we call sprintf like so:
+// On Solaris 9 and 32-bit Solaris 10/x86 before update 10, this test crashes
+// in libc.  Inside libstdc++, we call sprintf like so:
 //   sprintf (buffer, "%.*f", 1000, 1.0)
 // which crashes.
-// { dg-do run { xfail { i?86-*-solaris2.9 || { i?86-*-solaris2.10 && ilp32 } } } } 
+// { dg-do run { xfail { i?86-*-solaris2.9 } } } 
 
 // libstdc++/14220
 void test01()