Patchwork [U-Boot] mx28: Show CPU frequency

login
register
mail settings
Submitter Fabio Estevam
Date Jan. 23, 2012, 3:52 p.m.
Message ID <CAOMZO5CY9Xh2EqKmfWuymQ7Lp6GRcG6sxhkND8N65W9=PYYsVg@mail.gmail.com>
Download mbox | patch
Permalink /patch/137390/
State Rejected
Delegated to: Stefano Babic
Headers show

Comments

Fabio Estevam - Jan. 23, 2012, 3:52 p.m.
On 1/23/12, Marek Vasut <marek.vasut@gmail.com> wrote:

> Just put it amongst the other frequencies displayed by the clock command.

What about this?


It will print a lot more info though.

Regards,

Fabio Estevam
Stefano Babic - Jan. 23, 2012, 4:02 p.m.
On 23/01/2012 16:52, Fabio Estevam wrote:
> On 1/23/12, Marek Vasut <marek.vasut@gmail.com> wrote:
> 
>> Just put it amongst the other frequencies displayed by the clock command.
> 
> What about this?
> 
> --- a/arch/arm/cpu/arm926ejs/mx28/mx28.c
> +++ b/arch/arm/cpu/arm926ejs/mx28/mx28.c
> @@ -170,6 +170,7 @@ int arch_cpu_init(void)
>  int print_cpuinfo(void)
>  {
>         printf("Freescale i.MX28 family\n");
> +       do_mx28_showclocks();
>         return 0;
>  }
>  #endif
> 
> It will print a lot more info though.

Well, this is the reason we have a separate function / command (clocks)
that can be called only when needed. Generally, we avoid to print too
much information if they are not required and can slow down the boot
process.

In print_cpuinfo() we output the processor type, the revision if it is
available and maybe the processor frequency - nothing more. And if we
need a complete overview of the clocks, there is the "clocks" command.

So really I prefer the patch as it is - the information printed are the
same as for other SOCs, not only i.MX.

Best regards,
Stefano Babic
Marek Vasut - Jan. 23, 2012, 4:52 p.m.
> On 23/01/2012 16:52, Fabio Estevam wrote:
> > On 1/23/12, Marek Vasut <marek.vasut@gmail.com> wrote:
> >> Just put it amongst the other frequencies displayed by the clock
> >> command.
> > 
> > What about this?
> > 
> > --- a/arch/arm/cpu/arm926ejs/mx28/mx28.c
> > +++ b/arch/arm/cpu/arm926ejs/mx28/mx28.c
> > @@ -170,6 +170,7 @@ int arch_cpu_init(void)
> > 
> >  int print_cpuinfo(void)
> >  {
> >  
> >         printf("Freescale i.MX28 family\n");
> > 
> > +       do_mx28_showclocks();
> > 
> >         return 0;
> >  
> >  }
> >  #endif
> > 
> > It will print a lot more info though.
> 
> Well, this is the reason we have a separate function / command (clocks)
> that can be called only when needed. Generally, we avoid to print too
> much information if they are not required and can slow down the boot
> process.
> 
> In print_cpuinfo() we output the processor type, the revision if it is
> available and maybe the processor frequency - nothing more. And if we
> need a complete overview of the clocks, there is the "clocks" command.
> 
> So really I prefer the patch as it is - the information printed are the
> same as for other SOCs, not only i.MX.
> 
> Best regards,
> Stefano Babic

Ok, fine by me then.

Acked-by: Marek Vasut <marek.vasut@gmail.com>

M

Patch

--- a/arch/arm/cpu/arm926ejs/mx28/mx28.c
+++ b/arch/arm/cpu/arm926ejs/mx28/mx28.c
@@ -170,6 +170,7 @@  int arch_cpu_init(void)
 int print_cpuinfo(void)
 {
        printf("Freescale i.MX28 family\n");
+       do_mx28_showclocks();
        return 0;
 }
 #endif