From patchwork Mon Jan 23 14:07:22 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aldy Hernandez X-Patchwork-Id: 137358 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 1850FB6FA2 for ; Tue, 24 Jan 2012 01:07:51 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1327932473; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Mailing-List:Precedence: List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=hOXyAKWFKVTtw/gUI6ASgW6l6sg=; b=e3vfpnVrb82Wdyo 8TBygB8OAlsfksN/FhUslFyUrZzILdsa/EIiDnWJmrZXu7W9gr0nlf/ac251jIqd UK1X6p08AZMedtu1CZ4vjaEH18epgkMDZUdYpfetez9vDjASbbazsKW+t+A5SDjU njL3EUI4G7SkvZVnSe/OooeLk5G4= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=hZdWspNtuJKU3kKSCKCN6BqMKBw4QuEYlWn4jkvB2/eHc0MMefi8quamWDLGOb +pODDbaZsAc0c8oAbIqZMgOLRXZLbyXtpPbuMeaX5to0U6uzVg0fYxUiNbiNimHW ai/+nEXKAAi0o/YAcfn7oVO1nDV93yX3D4r+kvcwWt0/Q=; Received: (qmail 28943 invoked by alias); 23 Jan 2012 14:07:43 -0000 Received: (qmail 28920 invoked by uid 22791); 23 Jan 2012 14:07:42 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_HI, SPF_HELO_PASS, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 23 Jan 2012 14:07:24 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q0NE7OxU013649 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 23 Jan 2012 09:07:24 -0500 Received: from houston.quesejoda.com (vpn-232-218.phx2.redhat.com [10.3.232.218]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q0NE7M2d015646; Mon, 23 Jan 2012 09:07:22 -0500 Message-ID: <4F1D699A.2050704@redhat.com> Date: Mon, 23 Jan 2012 08:07:22 -0600 From: Aldy Hernandez User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111222 Thunderbird/9.0 MIME-Version: 1.0 To: Patrick Marlier CC: Dominique Dhumieres , gcc-patches@gcc.gnu.org, Iain Sandoe Subject: Re: [PATCH] PR51280 LTO/trans-mem ICE with TM builtins References: <20120120130449.5729E3BE18@mailhost.lps.ens.fr> <4F1B432E.8080405@gmail.com> In-Reply-To: <4F1B432E.8080405@gmail.com> Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org > PR lto/51916 > * lto-object.c (LTO_SEGMENT_NAME): Define segment name. > (lto_obj_file_open): Use it. Patrick, the changelog was referring to the wrong file and the wrong function. I've fixed it. I also inlined the segment name, as Ian had in the PR. Richard Guenther approved the patch on the PR, so I am committing and closing the PR. The final version of the patch is attached. Thanks for fixing this! PR lto/51916 * lto-wrapper.c (run_gcc): Pass the LTO section name to simple_object_start_read. Index: lto-wrapper.c =================================================================== --- lto-wrapper.c (revision 183432) +++ lto-wrapper.c (working copy) @@ -479,7 +479,8 @@ run_gcc (unsigned argc, char *argv[]) fd = open (argv[i], O_RDONLY); if (fd == -1) continue; - sobj = simple_object_start_read (fd, file_offset, NULL, &errmsg, &err); + sobj = simple_object_start_read (fd, file_offset, "__GNU_LTO", + &errmsg, &err); if (!sobj) { close (fd);