diff mbox

ethtool: allow ETHTOOL_GSSET_INFO for users

Message ID 197ddc79ac33a67c56b42a226af3f30056bceb5c.1327227549.git.mirq-linux@rere.qmqm.pl
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Michał Mirosław Jan. 22, 2012, 10:20 a.m. UTC
Allow ETHTOOL_GSSET_INFO ethtool ioctl() for unprivileged users.
ETHTOOL_GSTRINGS is already allowed, but is unusable without this one.

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
---
 net/core/ethtool.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

[against net, but probably suitable for stable, too]

Comments

Ben Hutchings Jan. 23, 2012, 1:19 a.m. UTC | #1
On Sun, 2012-01-22 at 11:20 +0100, Michał Mirosław wrote:
> Allow ETHTOOL_GSSET_INFO ethtool ioctl() for unprivileged users.
> ETHTOOL_GSTRINGS is already allowed, but is unusable without this one.
> 
> Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Acked-by: Ben Hutchings <bhutchings@solarflare.com>

We should probably also add:

ETHTOOL_GLINK
ETHTOOL_GRXFHINDIR
ETHTOOL_GCHANNELS

Ben.

> ---
>  net/core/ethtool.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> [against net, but probably suitable for stable, too]
> 
> diff --git a/net/core/ethtool.c b/net/core/ethtool.c
> index 921aa2b..369b418 100644
> --- a/net/core/ethtool.c
> +++ b/net/core/ethtool.c
> @@ -1311,6 +1311,7 @@ int dev_ethtool(struct net *net, struct ifreq *ifr)
>  	case ETHTOOL_GRXCSUM:
>  	case ETHTOOL_GTXCSUM:
>  	case ETHTOOL_GSG:
> +	case ETHTOOL_GSSET_INFO:
>  	case ETHTOOL_GSTRINGS:
>  	case ETHTOOL_GTSO:
>  	case ETHTOOL_GPERMADDR:
David Miller Jan. 23, 2012, 4:41 a.m. UTC | #2
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Mon, 23 Jan 2012 01:19:17 +0000

> On Sun, 2012-01-22 at 11:20 +0100, Michał Mirosław wrote:
>> Allow ETHTOOL_GSSET_INFO ethtool ioctl() for unprivileged users.
>> ETHTOOL_GSTRINGS is already allowed, but is unusable without this one.
>> 
>> Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
> Acked-by: Ben Hutchings <bhutchings@solarflare.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/net/core/ethtool.c b/net/core/ethtool.c
index 921aa2b..369b418 100644
--- a/net/core/ethtool.c
+++ b/net/core/ethtool.c
@@ -1311,6 +1311,7 @@  int dev_ethtool(struct net *net, struct ifreq *ifr)
 	case ETHTOOL_GRXCSUM:
 	case ETHTOOL_GTXCSUM:
 	case ETHTOOL_GSG:
+	case ETHTOOL_GSSET_INFO:
 	case ETHTOOL_GSTRINGS:
 	case ETHTOOL_GTSO:
 	case ETHTOOL_GPERMADDR: