Patchwork [16/26] Fix dirty logging with 32-bit qemu & 64-bit guests

login
register
mail settings
Submitter Alexander Graf
Date Jan. 21, 2012, 4:19 a.m.
Message ID <1327119551-29674-17-git-send-email-agraf@suse.de>
Download mbox | patch
Permalink /patch/137161/
State New
Headers show

Comments

Alexander Graf - Jan. 21, 2012, 4:19 a.m.
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>

The kvm_get_dirty_pages_log_range() function uses two address
variables to step through the monitored memory region to update the
dirty log.  However, these variables have type unsigned long, which
can overflow if running a 64-bit guest with a 32-bit qemu binary.

This patch changes these to target_phys_addr_t which will have the
correct size.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Alexander Graf <agraf@suse.de>
---
 kvm-all.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

Patch

diff --git a/kvm-all.c b/kvm-all.c
index 2cc4562..9e84d35 100644
--- a/kvm-all.c
+++ b/kvm-all.c
@@ -344,7 +344,8 @@  static int kvm_get_dirty_pages_log_range(MemoryRegionSection *section,
                                          unsigned long *bitmap)
 {
     unsigned int i, j;
-    unsigned long page_number, addr, addr1, c;
+    unsigned long page_number, c;
+    target_phys_addr_t addr, addr1;
     unsigned int len = ((section->size / TARGET_PAGE_SIZE) + HOST_LONG_BITS - 1) / HOST_LONG_BITS;
 
     /*