From patchwork Fri Jan 20 22:12:49 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Dunn X-Patchwork-Id: 137119 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:4978:20e::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 69B731007D5 for ; Sat, 21 Jan 2012 09:15:09 +1100 (EST) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1RoMiZ-0007Zv-TW; Fri, 20 Jan 2012 22:13:55 +0000 Received: from casper.infradead.org ([2001:770:15f::2]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1RoMiX-0007Zq-Ii for linux-mtd@merlin.infradead.org; Fri, 20 Jan 2012 22:13:53 +0000 Received: from smtp3.newsguy.com ([74.209.136.66] helo=smtp.newsguy.com) by casper.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1RoMiU-0002Rk-7x for linux-mtd@lists.infradead.org; Fri, 20 Jan 2012 22:13:51 +0000 Received: from localhost.localdomain (5.sub-166-250-10.myvzw.com [166.250.10.5]) by smtp.newsguy.com (8.14.3/8.14.3) with ESMTP id q0KMDfRB088068 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 20 Jan 2012 14:13:42 -0800 (PST) (envelope-from mikedunn@newsguy.com) From: Mike Dunn To: linux-mtd@lists.infradead.org Subject: [PATCH] MTD: docg4: fix compiler warning Date: Fri, 20 Jan 2012 14:12:49 -0800 Message-Id: <1327097569-6303-1-git-send-email-mikedunn@newsguy.com> X-Mailer: git-send-email 1.7.3.4 To: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20120120_221350_674911_4EFDD7FD X-CRM114-Status: GOOD ( 11.74 ) X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.3.2 on casper.infradead.org summary: Content analysis details: (-1.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Robert Jarzmik , Mike Dunn X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org This changes the declaration of the module parameter variable from int to bool, an oversight that was flagged by the recent patch to moduleparam.h. Also added an item to the TODO list in the commentary at the top of the file. Signed-off-by: Mike Dunn --- drivers/mtd/nand/docg4.c | 9 +++++++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/nand/docg4.c b/drivers/mtd/nand/docg4.c index 0132745..3ec1d10 100644 --- a/drivers/mtd/nand/docg4.c +++ b/drivers/mtd/nand/docg4.c @@ -20,6 +20,11 @@ * * Hamming ecc when reading oob only * + * According to the M-Sys documentation, this device is also available in a + * "dual-die" configuration having a 256MB capacity, but no mechanism for + * detecting this variant is documented. Currently this driver assumes 128MB + * capacity. + * * Support for multiple cascaded devices ("floors"). Not sure which gadgets * contain multiple G4s in a cascaded configuration, if any. * @@ -48,8 +53,8 @@ * it does not use mtd nand's method for marking bad blocks (using oob area). * This will also skip the check of the "page written" flag. */ -static int ignore_badblocks; -module_param(ignore_badblocks, bool, false); +static bool ignore_badblocks; +module_param(ignore_badblocks, bool, 0); MODULE_PARM_DESC(ignore_badblocks, "no badblock checking performed"); struct docg4_priv {