Patchwork MTD: docg4: fix compiler warning

login
register
mail settings
Submitter Mike Dunn
Date Jan. 20, 2012, 10:12 p.m.
Message ID <1327097569-6303-1-git-send-email-mikedunn@newsguy.com>
Download mbox | patch
Permalink /patch/137119/
State New
Headers show

Comments

Mike Dunn - Jan. 20, 2012, 10:12 p.m.
This changes the declaration of the module parameter variable from int to bool,
an oversight that was flagged by the recent patch to moduleparam.h.

Also added an item to the TODO list in the commentary at the top of the file.

Signed-off-by: Mike Dunn <mikedunn@newsguy.com>
---
 drivers/mtd/nand/docg4.c |    9 +++++++--
 1 files changed, 7 insertions(+), 2 deletions(-)
Artem Bityutskiy - Jan. 27, 2012, 3:07 p.m.
On Fri, 2012-01-20 at 14:12 -0800, Mike Dunn wrote:
> This changes the declaration of the module parameter variable from int to bool,
> an oversight that was flagged by the recent patch to moduleparam.h.
> 
> Also added an item to the TODO list in the commentary at the top of the file.
> 
> Signed-off-by: Mike Dunn <mikedunn@newsguy.com>

I've squashed this into your original driver and pushed to l2-mtd.git,
thanks.

Still wonder why it lives in mtd/nand while some other DoC drivers live
in mtd/devices ?

Patch

diff --git a/drivers/mtd/nand/docg4.c b/drivers/mtd/nand/docg4.c
index 0132745..3ec1d10 100644
--- a/drivers/mtd/nand/docg4.c
+++ b/drivers/mtd/nand/docg4.c
@@ -20,6 +20,11 @@ 
  *
  *  Hamming ecc when reading oob only
  *
+ *  According to the M-Sys documentation, this device is also available in a
+ *  "dual-die" configuration having a 256MB capacity, but no mechanism for
+ *  detecting this variant is documented.  Currently this driver assumes 128MB
+ *  capacity.
+ *
  *  Support for multiple cascaded devices ("floors").  Not sure which gadgets
  *  contain multiple G4s in a cascaded configuration, if any.
  *
@@ -48,8 +53,8 @@ 
  * it does not use mtd nand's method for marking bad blocks (using oob area).
  * This will also skip the check of the "page written" flag.
  */
-static int ignore_badblocks;
-module_param(ignore_badblocks, bool, false);
+static bool ignore_badblocks;
+module_param(ignore_badblocks, bool, 0);
 MODULE_PARM_DESC(ignore_badblocks, "no badblock checking performed");
 
 struct docg4_priv {