Patchwork mtd: mtdoops: kill Kconfig usage instructions

login
register
mail settings
Submitter Brian Norris
Date Jan. 20, 2012, 9:17 p.m.
Message ID <1327094220-26296-1-git-send-email-computersforpeace@gmail.com>
Download mbox | patch
Permalink /patch/137111/
State Accepted
Commit f0e0c09b88b23ec418c065739096e198e8d6be22
Headers show

Comments

Brian Norris - Jan. 20, 2012, 9:17 p.m.
The mtdoops usage instructions found in Kconfig have been incorrect
since:

    commit 2e386e4bac90554887e73d6f342e845185b33fc3
    mtd: mtdoops: refactor as a kmsg_dumper

mtdoops no longer uses a console. Now, if you build it into your kernel,
you add something like the following to your command line to select
partition X as your logging partition:

    mtdoops.mtddev=X

Anyway, it seems better to leave the documentation out of Kconfig.

Signed-off-by: Brian Norris <computersforpeace@gmail.com>
---
 drivers/mtd/Kconfig |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
Artem Bityutskiy - Jan. 27, 2012, 2:16 p.m.
On Fri, 2012-01-20 at 13:17 -0800, Brian Norris wrote:
> The mtdoops usage instructions found in Kconfig have been incorrect
> since:
> 
>     commit 2e386e4bac90554887e73d6f342e845185b33fc3
>     mtd: mtdoops: refactor as a kmsg_dumper
> 
> mtdoops no longer uses a console. Now, if you build it into your kernel,
> you add something like the following to your command line to select
> partition X as your logging partition:
> 
>     mtdoops.mtddev=X

Pushed to l2-mtd git tree, thanks!

Patch

diff --git a/drivers/mtd/Kconfig b/drivers/mtd/Kconfig
index 1be6218..58c6020 100644
--- a/drivers/mtd/Kconfig
+++ b/drivers/mtd/Kconfig
@@ -304,9 +304,6 @@  config MTD_OOPS
 	  buffer in a flash partition where it can be read back at some
 	  later point.
 
-	  To use, add console=ttyMTDx to the kernel command line,
-	  where x is the MTD device number to use.
-
 config MTD_SWAP
 	tristate "Swap on MTD device support"
 	depends on MTD && SWAP