Message ID | 1327086442-18016-3-git-send-email-vapier@gentoo.org |
---|---|
State | Accepted |
Commit | feb12a1f6d4d9958ab019a3fa6a820244072c889 |
Delegated to: | Wolfgang Denk |
Headers | show |
Dear Mike Frysinger, In message <1327086442-18016-3-git-send-email-vapier@gentoo.org> you wrote: > Simplify the code slightly by using a for() loop since this is > basically what we're already doing -- incrementing "ngood" to > the value in "count". > > Signed-off-by: Mike Frysinger <vapier@gentoo.org> > --- > common/cmd_mem.c | 7 ++----- > 1 files changed, 2 insertions(+), 5 deletions(-) Applied, thanks. Best regards, Wolfgang Denk
diff --git a/common/cmd_mem.c b/common/cmd_mem.c index 03e7f87..7a5addc 100644 --- a/common/cmd_mem.c +++ b/common/cmd_mem.c @@ -296,9 +296,7 @@ int do_mem_cmp (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) } #endif - ngood = 0; - - while (count-- > 0) { + for (ngood = 0; ngood < count; ++ngood) { ulong word1, word2; if (size == 4) { word1 = *(ulong *)addr1; @@ -318,12 +316,11 @@ int do_mem_cmp (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) break; } - ngood++; addr1 += size; addr2 += size; /* reset watchdog from time to time */ - if ((count % (64 << 10)) == 0) + if ((ngood % (64 << 10)) == 0) WATCHDOG_RESET(); }
Simplify the code slightly by using a for() loop since this is basically what we're already doing -- incrementing "ngood" to the value in "count". Signed-off-by: Mike Frysinger <vapier@gentoo.org> --- common/cmd_mem.c | 7 ++----- 1 files changed, 2 insertions(+), 5 deletions(-)