From patchwork Fri Dec 12 09:52:45 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kirsher, Jeffrey T" X-Patchwork-Id: 13694 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 9676CDDF18 for ; Fri, 12 Dec 2008 20:53:15 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756767AbYLLJxM (ORCPT ); Fri, 12 Dec 2008 04:53:12 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756694AbYLLJxJ (ORCPT ); Fri, 12 Dec 2008 04:53:09 -0500 Received: from qmta04.westchester.pa.mail.comcast.net ([76.96.62.40]:60169 "EHLO QMTA04.westchester.pa.mail.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756541AbYLLJxI (ORCPT ); Fri, 12 Dec 2008 04:53:08 -0500 Received: from OMTA03.westchester.pa.mail.comcast.net ([76.96.62.27]) by QMTA04.westchester.pa.mail.comcast.net with comcast id q9p71a0090bG4ec549t66K; Fri, 12 Dec 2008 09:53:06 +0000 Received: from lost.foo-projects.org ([63.64.152.142]) by OMTA03.westchester.pa.mail.comcast.net with comcast id q9sl1a00834bfcX3P9snRA; Fri, 12 Dec 2008 09:53:04 +0000 From: Jeff Kirsher Subject: [NET-NEXT PATCH 2/2] net: fix dcbnl_setnumtcs operation check To: davem@davemloft.net Cc: netdev@vger.kernel.org, jeff@garzik.org, Don Skidmore , Eric W Multanen , Peter P Waskiewicz Jr , Jeff Kirsher Date: Fri, 12 Dec 2008 01:52:45 -0800 Message-ID: <20081212095244.4416.19017.stgit@lost.foo-projects.org> In-Reply-To: <20081212095221.4416.83327.stgit@lost.foo-projects.org> References: <20081212095221.4416.83327.stgit@lost.foo-projects.org> User-Agent: StGIT/0.14.3 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Don Skidmore dcbml_setnumtcs wasn't checking for the presence of the setnumtcs function. Instead, it was checking for setstate which was a bug. Signed-off-by: Don Skidmore Signed-off-by: Eric W Multanen Signed-off-by: Peter P Waskiewicz Jr Signed-off-by: Jeff Kirsher --- net/dcb/dcbnl.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/dcb/dcbnl.c b/net/dcb/dcbnl.c index d0c12f0..fc88fc4 100644 --- a/net/dcb/dcbnl.c +++ b/net/dcb/dcbnl.c @@ -469,7 +469,7 @@ static int dcbnl_setnumtcs(struct net_device *netdev, struct nlattr **tb, u8 value; int i; - if (!tb[DCB_ATTR_NUMTCS] || !netdev->dcbnl_ops->setstate) + if (!tb[DCB_ATTR_NUMTCS] || !netdev->dcbnl_ops->setnumtcs) return ret; ret = nla_parse_nested(data, DCB_NUMTCS_ATTR_MAX, tb[DCB_ATTR_NUMTCS],