From patchwork Thu Jan 19 23:35:24 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andreas_F=C3=A4rber?= X-Patchwork-Id: 136924 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id CB0ED1007D3 for ; Fri, 20 Jan 2012 11:04:43 +1100 (EST) Received: from localhost ([::1]:56915 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ro1Za-000274-Ji for incoming@patchwork.ozlabs.org; Thu, 19 Jan 2012 18:39:14 -0500 Received: from eggs.gnu.org ([140.186.70.92]:44674) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ro1YI-0007Mv-4X for qemu-devel@nongnu.org; Thu, 19 Jan 2012 18:37:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ro1YG-0004pU-BS for qemu-devel@nongnu.org; Thu, 19 Jan 2012 18:37:53 -0500 Received: from mout.web.de ([212.227.15.3]:60689) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ro1YG-0004pD-0Q; Thu, 19 Jan 2012 18:37:52 -0500 Received: from localhost.localdomain ([84.148.33.51]) by smtp.web.de (mrweb001) with ESMTPA (Nemesis) id 0MTQ07-1SGO2h13l1-00S1Fr; Fri, 20 Jan 2012 00:37:36 +0100 From: =?UTF-8?q?Andreas=20F=C3=A4rber?= To: qemu-devel@nongnu.org Date: Fri, 20 Jan 2012 00:35:24 +0100 Message-Id: <1327016131-5344-4-git-send-email-andreas.faerber@web.de> X-Mailer: git-send-email 1.7.7 In-Reply-To: <1327016131-5344-1-git-send-email-andreas.faerber@web.de> References: <1327016131-5344-1-git-send-email-andreas.faerber@web.de> MIME-Version: 1.0 X-Provags-ID: V02:K0:yJAcOkRyiJgVq14T550EzpHkpPyaZ9FWmcxqE04h42e R4gqXiRe3Aep+ClH0nEDR58QXgt3hfb7oaRgD1lQSBJbNJrloI jxjoSU6Sr0Ac/TOB+aP1MM2FPMoiZalGImLyVtbTNSkJRe1TBW 8hnCyOvZJb0hWeMd9Ebdz8/w049EuTbEx6Pn+u1ozWkRVYnkc1 sqNUZXW32AgDP0DbAQ0KA== X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 212.227.15.3 Cc: Anthony Liguori , "Michael S. Tsirkin" , Alexander Graf , =?UTF-8?q?Andreas=20F=C3=A4rber?= , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Avi Kivity , qemu-ppc@nongnu.org, Richard Henderson Subject: [Qemu-devel] [PATCH 03/10] prep: qdev'ify Raven host bridge (PCIDevice) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Move initialization of vendor ID, etc. to PCIDeviceInfo. Introduce VMState. Signed-off-by: Andreas Färber Reviewed-by: Alexander Graf Cc: Hervé Poussineau Cc: Michael S. Tsirkin Cc: Anthony Liguori --- hw/prep_pci.c | 55 ++++++++++++++++++++++++++++++++++++++++++++++--------- 1 files changed, 46 insertions(+), 9 deletions(-) diff --git a/hw/prep_pci.c b/hw/prep_pci.c index ea9fb69..741b273 100644 --- a/hw/prep_pci.c +++ b/hw/prep_pci.c @@ -29,6 +29,10 @@ typedef PCIHostState PREPPCIState; +typedef struct RavenPCIState { + PCIDevice dev; +} RavenPCIState; + static inline uint32_t PPC_PCIIO_config(target_phys_addr_t addr) { int i; @@ -111,7 +115,6 @@ PCIBus *pci_prep_init(qemu_irq *pic, MemoryRegion *address_space_io) { PREPPCIState *s; - PCIDevice *d; s = g_malloc0(sizeof(PREPPCIState)); s->bus = pci_register_bus(NULL, "pci", @@ -133,16 +136,50 @@ PCIBus *pci_prep_init(qemu_irq *pic, memory_region_init_io(&s->mmcfg, &PPC_PCIIO_ops, s, "pciio", 0x00400000); memory_region_add_subregion(address_space_mem, 0x80800000, &s->mmcfg); - /* PCI host bridge */ - d = pci_register_device(s->bus, "PREP Host Bridge - Motorola Raven", - sizeof(PCIDevice), 0, NULL, NULL); - pci_config_set_vendor_id(d->config, PCI_VENDOR_ID_MOTOROLA); - pci_config_set_device_id(d->config, PCI_DEVICE_ID_MOTOROLA_RAVEN); - d->config[0x08] = 0x00; // revision - pci_config_set_class(d->config, PCI_CLASS_BRIDGE_HOST); + pci_create_simple(s->bus, 0, "raven"); + + return s->bus; +} + +static int raven_init(PCIDevice *d) +{ d->config[0x0C] = 0x08; // cache_line_size d->config[0x0D] = 0x10; // latency_timer d->config[0x34] = 0x00; // capabilities_pointer - return s->bus; + return 0; } + +static const VMStateDescription vmstate_raven = { + .name = "raven", + .version_id = 0, + .minimum_version_id = 0, + .fields = (VMStateField[]) { + VMSTATE_PCI_DEVICE(dev, RavenPCIState), + VMSTATE_END_OF_LIST() + }, +}; + +static PCIDeviceInfo raven_info = { + .qdev.name = "raven", + .qdev.desc = "PReP Host Bridge - Motorola Raven", + .qdev.size = sizeof(RavenPCIState), + .qdev.vmsd = &vmstate_raven, + .qdev.no_user = 1, + .no_hotplug = 1, + .init = raven_init, + .vendor_id = PCI_VENDOR_ID_MOTOROLA, + .device_id = PCI_DEVICE_ID_MOTOROLA_RAVEN, + .revision = 0x00, + .class_id = PCI_CLASS_BRIDGE_HOST, + .qdev.props = (Property[]) { + DEFINE_PROP_END_OF_LIST() + }, +}; + +static void raven_register_devices(void) +{ + pci_qdev_register(&raven_info); +} + +device_init(raven_register_devices)