From patchwork Thu Jan 19 10:45:56 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mohan Kumar M X-Patchwork-Id: 136893 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 28F5FB6EE8 for ; Fri, 20 Jan 2012 05:26:15 +1100 (EST) Received: from localhost ([::1]:57632 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RnvS0-0005rX-Ay for incoming@patchwork.ozlabs.org; Thu, 19 Jan 2012 12:07:00 -0500 Received: from eggs.gnu.org ([140.186.70.92]:48615) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RnpVf-0005pw-96 for qemu-devel@nongnu.org; Thu, 19 Jan 2012 05:46:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RnpVU-00018Y-Ix for qemu-devel@nongnu.org; Thu, 19 Jan 2012 05:46:23 -0500 Received: from e28smtp02.in.ibm.com ([122.248.162.2]:59954) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RnpVT-00016V-NI for qemu-devel@nongnu.org; Thu, 19 Jan 2012 05:46:12 -0500 Received: from /spool/local by e28smtp02.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 19 Jan 2012 16:16:04 +0530 Received: from d28relay03.in.ibm.com (9.184.220.60) by e28smtp02.in.ibm.com (192.168.1.132) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 19 Jan 2012 16:16:01 +0530 Received: from d28av01.in.ibm.com (d28av01.in.ibm.com [9.184.220.63]) by d28relay03.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q0JAk0ko4489244 for ; Thu, 19 Jan 2012 16:16:01 +0530 Received: from d28av01.in.ibm.com (loopback [127.0.0.1]) by d28av01.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q0JAjxJp009154 for ; Thu, 19 Jan 2012 16:16:00 +0530 Received: from explorer.in.ibm.com (explorer.in.ibm.com [9.124.35.85]) by d28av01.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id q0JAjxb5009049; Thu, 19 Jan 2012 16:15:59 +0530 From: "M. Mohan Kumar" To: qemu-devel@nongnu.org, "Aneesh Kumar K.V" Date: Thu, 19 Jan 2012 16:15:56 +0530 Message-Id: <1326969956-11573-1-git-send-email-mohan@in.ibm.com> X-Mailer: git-send-email 1.7.6 x-cbid: 12011910-5816-0000-0000-000000F0DB1A X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 122.248.162.2 X-Mailman-Approved-At: Thu, 19 Jan 2012 12:06:34 -0500 Cc: "M. Mohan Kumar" Subject: [Qemu-devel] [PATCH] fsdev: parameter parsing for proxy helper X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: "M. Mohan Kumar" Signed-off-by: M. Mohan Kumar --- fsdev/virtfs-proxy-helper.c | 10 ++++++++-- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c index baafee2..5aafc38 100644 --- a/fsdev/virtfs-proxy-helper.c +++ b/fsdev/virtfs-proxy-helper.c @@ -1040,7 +1040,13 @@ int main(int argc, char **argv) return -1; } - if (*sock_name && (own_u == -1 || own_g == -1)) { + if (sock_name && sock != -1) { + fprintf(stderr, "both named socket and socket descriptor specified\n"); + usage(argv[0]); + exit(EXIT_FAILURE); + } + + if (sock_name && (own_u == -1 || own_g == -1)) { fprintf(stderr, "owner uid:gid not specified, "); fprintf(stderr, "owner uid:gid specifies who can access the socket file\n"); @@ -1068,7 +1074,7 @@ int main(int argc, char **argv) } do_log(LOG_INFO, "Started\n"); - if (*sock_name) { + if (sock_name) { sock = proxy_socket(sock_name, own_u, own_g); if (sock < 0) { goto error;