From patchwork Wed Jan 18 14:00:29 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aldy Hernandez X-Patchwork-Id: 136613 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id E0EFEB6EE7 for ; Thu, 19 Jan 2012 01:00:59 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1327500060; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Mailing-List:Precedence: List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=zZZ1oWrxWlWhQRmjboYiiUKX8BE=; b=siDBEsjO0uVzAoI SOCkrv0LzA06PpV1STGLlAQfv4DlO3YPVScX4Cq4+rCQtUwqEOmkCOHUYlTvDbIl GnsOTAuJHYnhf25Nq8+A/tUHHmWklZzbIxr9Q6IXnPv5UzmTLxr2k7sguqF9Qvq9 WKFxJ6q0NIY0q1aaJ5t2h6cUtass= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=GGffu9UEGal+fRyJIVeQ+xp/+uPYGOQL5nA4WuifDYl+fMxZ9FmwqkeYi76pYs GjNYxF/+X7cAbBShLg0Zfs1d6k5TLGdVbYJYnHnko3kPgpXBW2WtK3s6baazKu9Q 6jjcJGvzvFs38bQ2RmhHZHTEYaxhOd+3QQKT/u/uHn14E=; Received: (qmail 25847 invoked by alias); 18 Jan 2012 14:00:49 -0000 Received: (qmail 25837 invoked by uid 22791); 18 Jan 2012 14:00:47 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_HI, SPF_HELO_PASS, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 18 Jan 2012 14:00:31 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q0IE0U2v006893 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 18 Jan 2012 09:00:30 -0500 Received: from houston.quesejoda.com (vpn-232-198.phx2.redhat.com [10.3.232.198]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q0IE0TQl014172; Wed, 18 Jan 2012 09:00:29 -0500 Message-ID: <4F16D07D.6040405@redhat.com> Date: Wed, 18 Jan 2012 08:00:29 -0600 From: Aldy Hernandez User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111222 Thunderbird/9.0 MIME-Version: 1.0 To: Richard Guenther CC: Patrick Marlier , gcc-patches Subject: Re: PR other/51165: add new adress_escapes predicate References: <4F14342D.8080400@redhat.com> <4F144924.8030007@redhat.com> <4F1575B6.5000508@redhat.com> <4F15A4A9.10405@gmail.com> In-Reply-To: Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org >> So you can do probably the following: >> >> Index: trans-mem.c >> =================================================================== >> --- trans-mem.c (revision 183253) >> +++ trans-mem.c (working copy) >> @@ -1497,8 +1497,6 @@ requires_barrier (basic_block entry_block, tree x, >> to needs_to_live_in_memory until we eliminate >> lower_sequence_tm altogether. */ >> needs_to_live_in_memory (x) >> - /* X escapes. */ >> - || is_global_var (x)) > > True, because needs_to_live_in_memory is true for all global vars already > (and includes all address-taken automatic vars as well, thus may_be_aliased (x), > too). Sweet. Thanks guys. Richard, I assume you are OK with this? Tested on x86-64 Linux. * trans-mem.c (requires_barrier): Remove call to is_global_var. Index: trans-mem.c =================================================================== --- trans-mem.c (revision 183272) +++ trans-mem.c (working copy) @@ -1496,9 +1496,7 @@ requires_barrier (basic_block entry_bloc during lower_sequence_tm/gimplification, leave the call to needs_to_live_in_memory until we eliminate lower_sequence_tm altogether. */ - needs_to_live_in_memory (x) - /* X escapes. */ - || is_global_var (x)) + needs_to_live_in_memory (x)) return true; else {