| Message ID | 20120117204843.GA20999@elgon.mountain |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Dan Carpenter <dan.carpenter@oracle.com> Date: Tue, 17 Jan 2012 23:48:43 +0300 > kmemcheck complains that ->redirect_genid doesn't get initialized. > Presumably it should be set to zero. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> It's a "don't care" until we actually get a redirect, but I've applied your patch nonetheless. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Le mardi 17 janvier 2012 à 23:48 +0300, Dan Carpenter a écrit : > kmemcheck complains that ->redirect_genid doesn't get initialized. > Presumably it should be set to zero. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > diff --git a/net/ipv4/inetpeer.c b/net/ipv4/inetpeer.c > index 86f13c67..49ce5f4 100644 > --- a/net/ipv4/inetpeer.c > +++ b/net/ipv4/inetpeer.c > @@ -447,6 +447,7 @@ relookup: > p->rate_last = 0; > p->pmtu_expires = 0; > p->pmtu_orig = 0; > + p->redirect_genid = 0; > memset(&p->redirect_learned, 0, sizeof(p->redirect_learned)); > > We dont really care, since we force redirect_learned.a4 to be 0 Only place we care is in ip_rt_redirect() and its done properly there. Lets shutup kmemcheck. Acked-by: Eric Dumazet <eric.dumazet@gmail.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Le mardi 17 janvier 2012 à 15:52 -0500, David Miller a écrit : > From: Dan Carpenter <dan.carpenter@oracle.com> > Date: Tue, 17 Jan 2012 23:48:43 +0300 > > > kmemcheck complains that ->redirect_genid doesn't get initialized. > > Presumably it should be set to zero. > > > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > It's a "don't care" until we actually get a redirect, but I've applied > your patch nonetheless. > ;) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/ipv4/inetpeer.c b/net/ipv4/inetpeer.c index 86f13c67..49ce5f4 100644 --- a/net/ipv4/inetpeer.c +++ b/net/ipv4/inetpeer.c @@ -447,6 +447,7 @@ relookup: p->rate_last = 0; p->pmtu_expires = 0; p->pmtu_orig = 0; + p->redirect_genid = 0; memset(&p->redirect_learned, 0, sizeof(p->redirect_learned));
kmemcheck complains that ->redirect_genid doesn't get initialized. Presumably it should be set to zero. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html