Patchwork [RFC,V2,5/8] netback: add module get/put operations along with vif connect/disconnect.

login
register
mail settings
Submitter Wei Liu
Date Jan. 17, 2012, 1:47 p.m.
Message ID <1326808024-3744-6-git-send-email-wei.liu2@citrix.com>
Download mbox | patch
Permalink /patch/136474/
State RFC
Delegated to: David Miller
Headers show

Comments

Wei Liu - Jan. 17, 2012, 1:47 p.m.
If there is vif running and user unloads netback, it will certainly
cause problems -- guest's network interface just mysteriously stops
working.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
 drivers/net/xen-netback/interface.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

Patch

diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c
index dfc04f8..7c86187 100644
--- a/drivers/net/xen-netback/interface.c
+++ b/drivers/net/xen-netback/interface.c
@@ -323,6 +323,8 @@  int xenvif_connect(struct xenvif *vif, unsigned long tx_ring_ref,
 	if (vif->irq)
 		return 0;
 
+	__module_get(THIS_MODULE);
+
 	err = xen_netbk_map_frontend_rings(vif, tx_ring_ref, rx_ring_ref);
 	if (err < 0)
 		goto err;
@@ -405,4 +407,6 @@  void xenvif_disconnect(struct xenvif *vif)
 	xen_netbk_unmap_frontend_rings(vif);
 
 	free_netdev(vif->dev);
+
+	module_put(THIS_MODULE);
 }