Patchwork [v2] lm32: Fix mixup of uint32 and uint32_t

login
register
mail settings
Submitter Andreas Färber
Date Jan. 17, 2012, 9:44 a.m.
Message ID <1326793481-3967-1-git-send-email-afaerber@suse.de>
Download mbox | patch
Permalink /patch/136435/
State New
Headers show

Comments

Andreas Färber - Jan. 17, 2012, 9:44 a.m.
Commit d23948b15a9920fb7f6374b55a6db1ecff81f3ee (lm32: add Milkymist
VGAFB support) introduced a stray usage of the softfloat uint32 type.

Use uint32_t instead.

Signed-off-by: Andreas Färber <afaerber@suse.de>
Acked-by: Michael Walle <michael@walle.cc>
Cc: Peter Maydell <peter.maydell@linaro.org>
---
 hw/milkymist-vgafb_template.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Stefan Hajnoczi - Jan. 19, 2012, 8:17 a.m.
On Tue, Jan 17, 2012 at 10:44:40AM +0100, Andreas Färber wrote:
> Commit d23948b15a9920fb7f6374b55a6db1ecff81f3ee (lm32: add Milkymist
> VGAFB support) introduced a stray usage of the softfloat uint32 type.
> 
> Use uint32_t instead.
> 
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> Acked-by: Michael Walle <michael@walle.cc>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> ---
>  hw/milkymist-vgafb_template.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches

Stefan

Patch

diff --git a/hw/milkymist-vgafb_template.h b/hw/milkymist-vgafb_template.h
index 69af9ef..1d33ee8 100644
--- a/hw/milkymist-vgafb_template.h
+++ b/hw/milkymist-vgafb_template.h
@@ -39,7 +39,7 @@ 
 #elif BITS == 24
 #define COPY_PIXEL(to, r, g, b)                    \
     do {                                           \
-        uint32 tmp = rgb_to_pixel24(r, g, b);      \
+        uint32_t tmp = rgb_to_pixel24(r, g, b);    \
         *(to++) =         tmp & 0xff;              \
         *(to++) =  (tmp >> 8) & 0xff;              \
         *(to++) = (tmp >> 16) & 0xff;              \