Patchwork [net,2/2] net: WARN if skb_checksum_help() is called on skb requiring segmentation

login
register
mail settings
Submitter Ben Hutchings
Date Jan. 16, 2012, 10:43 p.m.
Message ID <1326753818.3065.35.camel@bwh-desktop>
Download mbox | patch
Permalink /patch/136376/
State Changes Requested
Delegated to: David Miller
Headers show

Comments

Ben Hutchings - Jan. 16, 2012, 10:43 p.m.
skb_checksum_help() has never done anything useful with skbs that
require segmentation.  Setting skb->ip_summed = CHECKSUM_NONE makes
them invalid and provokes a later WARNing in skb_gso_segment().

Passing such an skb to skb_checksum_help() indicates a bug, so we
should warn about it immediately.  Move the warning from
skb_gso_segment() into a shared function, and add the calling function
name, gso_type and gso_size to it.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
---
The price for writing the warning format only once is having to pass in
the calling function name.  Not sure whether it's a good trade-off.

Ben.

 net/core/dev.c |   31 +++++++++++++++++++------------
 1 files changed, 19 insertions(+), 12 deletions(-)
Herbert Xu - Jan. 17, 2012, 6:11 a.m.
On Mon, Jan 16, 2012 at 10:43:38PM +0000, Ben Hutchings wrote:
> skb_checksum_help() has never done anything useful with skbs that
> require segmentation.  Setting skb->ip_summed = CHECKSUM_NONE makes
> them invalid and provokes a later WARNing in skb_gso_segment().
> 
> Passing such an skb to skb_checksum_help() indicates a bug, so we
> should warn about it immediately.  Move the warning from
> skb_gso_segment() into a shared function, and add the calling function
> name, gso_type and gso_size to it.
> 
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
> ---
> The price for writing the warning format only once is having to pass in
> the calling function name.  Not sure whether it's a good trade-off.

Do we really need the name since we should get a back trace?

Cheers,
David Miller - Jan. 17, 2012, 3:32 p.m.
From: Herbert Xu <herbert@gondor.hengli.com.au>
Date: Tue, 17 Jan 2012 17:11:15 +1100

> On Mon, Jan 16, 2012 at 10:43:38PM +0000, Ben Hutchings wrote:
>> skb_checksum_help() has never done anything useful with skbs that
>> require segmentation.  Setting skb->ip_summed = CHECKSUM_NONE makes
>> them invalid and provokes a later WARNing in skb_gso_segment().
>> 
>> Passing such an skb to skb_checksum_help() indicates a bug, so we
>> should warn about it immediately.  Move the warning from
>> skb_gso_segment() into a shared function, and add the calling function
>> name, gso_type and gso_size to it.
>> 
>> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
>> ---
>> The price for writing the warning format only once is having to pass in
>> the calling function name.  Not sure whether it's a good trade-off.
> 
> Do we really need the name since we should get a back trace?

Agreed.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Ben Hutchings - Jan. 17, 2012, 5:15 p.m.
On Tue, 2012-01-17 at 17:11 +1100, Herbert Xu wrote:
> On Mon, Jan 16, 2012 at 10:43:38PM +0000, Ben Hutchings wrote:
> > skb_checksum_help() has never done anything useful with skbs that
> > require segmentation.  Setting skb->ip_summed = CHECKSUM_NONE makes
> > them invalid and provokes a later WARNing in skb_gso_segment().
> > 
> > Passing such an skb to skb_checksum_help() indicates a bug, so we
> > should warn about it immediately.  Move the warning from
> > skb_gso_segment() into a shared function, and add the calling function
> > name, gso_type and gso_size to it.
> > 
> > Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
> > ---
> > The price for writing the warning format only once is having to pass in
> > the calling function name.  Not sure whether it's a good trade-off.
> 
> Do we really need the name since we should get a back trace?

If the compiler were to aggressively inline some of these functions then
it might no longer be clear where this was called from.  But I agree
that the name is normally redundant, so I'll take it out.

Ben.

Patch

diff --git a/net/core/dev.c b/net/core/dev.c
index 7e6b7dc..6824393 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -1887,6 +1887,22 @@  void skb_set_dev(struct sk_buff *skb, struct net_device *dev)
 EXPORT_SYMBOL(skb_set_dev);
 #endif /* CONFIG_NET_NS */
 
+static void skb_warn_bad_offload(const char *func, const struct sk_buff *skb)
+{
+	struct net_device *dev = skb->dev;
+	const char *driver = "";
+
+	if (dev && dev->dev.parent)
+		driver = dev_driver_string(dev->dev.parent);
+
+	WARN(1, "%s: in %s caps=(%pNF, %pNF) len=%d data_len=%d gso_size=%d "
+	     "gso_type=%d ip_summed=%d\n",
+	     driver, func, dev ? &dev->features : NULL,
+	     skb->sk ? &skb->sk->sk_route_caps : NULL,
+	     skb->len, skb->data_len, skb_shinfo(skb)->gso_size,
+	     skb_shinfo(skb)->gso_type, skb->ip_summed);
+}
+
 /*
  * Invalidate hardware checksum when packet is to be mangled, and
  * complete checksum manually on outgoing path.
@@ -1900,8 +1916,8 @@  int skb_checksum_help(struct sk_buff *skb)
 		goto out_set_summed;
 
 	if (unlikely(skb_shinfo(skb)->gso_size)) {
-		/* Let GSO fix up the checksum. */
-		goto out_set_summed;
+		skb_warn_bad_offload(__func__, skb);
+		return -EINVAL;
 	}
 
 	offset = skb_checksum_start_offset(skb);
@@ -1961,16 +1977,7 @@  struct sk_buff *skb_gso_segment(struct sk_buff *skb,
 	__skb_pull(skb, skb->mac_len);
 
 	if (unlikely(skb->ip_summed != CHECKSUM_PARTIAL)) {
-		struct net_device *dev = skb->dev;
-		const char *driver = "";
-
-		if (dev && dev->dev.parent)
-			driver = dev_driver_string(dev->dev.parent);
-
-		WARN(1, "%s: caps=(%pNF, %pNF) len=%d data_len=%d ip_summed=%d\n",
-		     driver, dev ? &dev->features : NULL,
-		     skb->sk ? &skb->sk->sk_route_caps : NULL,
-		     skb->len, skb->data_len, skb->ip_summed);
+		skb_warn_bad_offload(__func__, skb);
 
 		if (skb_header_cloned(skb) &&
 		    (err = pskb_expand_head(skb, 0, 0, GFP_ATOMIC)))