Patchwork [libitm,build] Support sun symbol versioning

login
register
mail settings
Submitter Rainer Orth
Date Jan. 16, 2012, 4:41 p.m.
Message ID <yddzkdn61mc.fsf@manam.CeBiTec.Uni-Bielefeld.DE>
Download mbox | patch
Permalink /patch/136312/
State New
Headers show

Comments

Rainer Orth - Jan. 16, 2012, 4:41 p.m.
Torvald Riegel <triegel@redhat.com> writes:

> On Mon, 2011-11-21 at 15:06 +0100, Rainer Orth wrote:
>> * _ITM_getThreadnum is the only symbol in libitm.map that isn't present
>>   in the library.  It's documented as missing and should perhaps be
>>   removed from the map?
>
> Yes, this is not supported anymore.

Here's the patch that removes it.  I think this should go in before
4.7.0 is released: if the function is added later, it would incorrectly
end up in the LIBITM_1.0, defeating the purpose of symbol versioning.

Bootstrapped without regressions on i386-pc-solaris2.11 and verified
that the symbol version info is unchanged.

Ok for mainline?

	Rainer


2012-01-14  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

	* libitm.h (_ITM_getThreadnum): Remove.
	* libitm.map (_ITM_getThreadnum): Remove from LIBITM_1.0.
Richard Henderson - Jan. 23, 2012, 12:41 a.m.
On 01/17/2012 03:41 AM, Rainer Orth wrote:
> 2012-01-14  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
> 
> 	* libitm.h (_ITM_getThreadnum): Remove.
> 	* libitm.map (_ITM_getThreadnum): Remove from LIBITM_1.0.

Ok.


r~

Patch

# HG changeset patch
# Parent e9235a85428f1c332d0b4346142aabc0d3c3990c
Remove _ITM_getThreadnum

diff --git a/libitm/libitm.h b/libitm/libitm.h
--- a/libitm/libitm.h
+++ b/libitm/libitm.h
@@ -1,4 +1,4 @@ 
-/* Copyright (C) 2008, 2009, 2011 Free Software Foundation, Inc.
+/* Copyright (C) 2008, 2009, 2011, 2012 Free Software Foundation, Inc.
    Contributed by Richard Henderson <rth@redhat.com>.
 
    This file is part of the GNU Transactional Memory Library (libitm).
@@ -149,8 +149,6 @@  extern void _ITM_addUserCommitAction(_IT
 
 extern void _ITM_addUserUndoAction(_ITM_userUndoFunction, void *) ITM_REGPARM;
 
-extern int _ITM_getThreadnum(void) ITM_REGPARM;
-
 extern void _ITM_dropReferences (void *, size_t) ITM_REGPARM ITM_PURE;
 
 extern void *_ITM_malloc (size_t)
diff --git a/libitm/libitm.map b/libitm/libitm.map
--- a/libitm/libitm.map
+++ b/libitm/libitm.map
@@ -8,7 +8,6 @@  LIBITM_1.0 {
 	_ITM_commitTransaction;
 	_ITM_commitTransactionEH;
 	_ITM_error;
-	_ITM_getThreadnum;
 	_ITM_getTransactionId;
 	_ITM_inTransaction;
 	_ITM_libraryVersion;