From patchwork Thu Dec 11 21:36:00 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hannes Eder X-Patchwork-Id: 13624 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id D712FDDF9B for ; Fri, 12 Dec 2008 10:00:58 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759405AbYLKXAa (ORCPT ); Thu, 11 Dec 2008 18:00:30 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759399AbYLKXA3 (ORCPT ); Thu, 11 Dec 2008 18:00:29 -0500 Received: from mail-bw0-f13.google.com ([209.85.218.13]:37330 "EHLO mail-bw0-f13.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759015AbYLKXAP (ORCPT ); Thu, 11 Dec 2008 18:00:15 -0500 Received: by bwz6 with SMTP id 6so2825072bwz.13 for ; Thu, 11 Dec 2008 15:00:13 -0800 (PST) Received: by 10.103.191.12 with SMTP id t12mr1623076mup.49.1229036070160; Thu, 11 Dec 2008 14:54:30 -0800 (PST) Received: from vmbox.hanneseder.net (chello080109038207.17.14.tuwien.teleweb.at [80.109.38.207]) by mx.google.com with ESMTPS id y2sm4981974mug.44.2008.12.11.14.54.26 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 11 Dec 2008 14:54:29 -0800 (PST) Message-ID: <49419a25.02e2660a.1ba9.6cda@mx.google.com> Received: by vmbox.hanneseder.net (sSMTP sendmail emulation); Thu, 11 Dec 2008 01:00:07 +0100 To: netdev@vger.kernel.org Cc: Karsten Keil Cc: linux-kernel@vger.kernel.org Cc: kernel-janitors@vger.kernel.org Date: Thu, 11 Dec 2008 22:36:00 +0100 Subject: [PATCH 2/9][v2] mISDN: consistently define 'debug' as '*u_int' From: Hannes Eder Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Impact: change data type for variable 'debug' from *int to *u_int, same for the argument type of mISDN_inittimer In "core.h" mISDN_inittimer is declared with the argument type "*u_int", make the definition in "timerdev.c" match this. This fixes also this warnings: drivers/isdn/mISDN/layer1.c:391:8: warning: incorrect type in assignment (different signedness) drivers/isdn/mISDN/layer1.c:391:8: expected int *static [toplevel] debug drivers/isdn/mISDN/layer1.c:391:8: got unsigned int [usertype] *deb drivers/isdn/mISDN/layer2.c:2200:8: warning: incorrect type in assignment (different signedness) drivers/isdn/mISDN/layer2.c:2200:8: expected int *static [toplevel] debug drivers/isdn/mISDN/layer2.c:2200:8: got unsigned int [usertype] *deb drivers/isdn/mISDN/socket.c:769:8: warning: incorrect type in assignment (different signedness) drivers/isdn/mISDN/socket.c:769:8: expected int *static [toplevel] debug drivers/isdn/mISDN/socket.c:769:8: got unsigned int [usertype] *deb Signed-off-by: Hannes Eder Acked-by: Karsten Keil --- drivers/isdn/mISDN/layer1.c | 2 +- drivers/isdn/mISDN/layer2.c | 2 +- drivers/isdn/mISDN/socket.c | 2 +- drivers/isdn/mISDN/timerdev.c | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/isdn/mISDN/layer1.c b/drivers/isdn/mISDN/layer1.c index fced1a2..4a55d63 100644 --- a/drivers/isdn/mISDN/layer1.c +++ b/drivers/isdn/mISDN/layer1.c @@ -21,7 +21,7 @@ #include "layer1.h" #include "fsm.h" -static int *debug; +static u_int *debug; struct layer1 { u_long Flags; diff --git a/drivers/isdn/mISDN/layer2.c b/drivers/isdn/mISDN/layer2.c index a7915a1..77fca3b 100644 --- a/drivers/isdn/mISDN/layer2.c +++ b/drivers/isdn/mISDN/layer2.c @@ -18,7 +18,7 @@ #include "fsm.h" #include "layer2.h" -static int *debug; +static u_int *debug; static struct Fsm l2fsm = {NULL, 0, 0, NULL, NULL}; diff --git a/drivers/isdn/mISDN/socket.c b/drivers/isdn/mISDN/socket.c index e5a20f9..37a2de1 100644 --- a/drivers/isdn/mISDN/socket.c +++ b/drivers/isdn/mISDN/socket.c @@ -18,7 +18,7 @@ #include #include "core.h" -static int *debug; +static u_int *debug; static struct proto mISDN_proto = { .name = "misdn", diff --git a/drivers/isdn/mISDN/timerdev.c b/drivers/isdn/mISDN/timerdev.c index 875fabe..a8d1d9f 100644 --- a/drivers/isdn/mISDN/timerdev.c +++ b/drivers/isdn/mISDN/timerdev.c @@ -24,7 +24,7 @@ #include #include -static int *debug; +static u_int *debug; struct mISDNtimerdev { @@ -274,7 +274,7 @@ static struct miscdevice mISDNtimer = { }; int -mISDN_inittimer(int *deb) +mISDN_inittimer(u_int *deb) { int err;