Patchwork [1/4] EAP SIM peer: append realm when learning the pseudonym

login
register
mail settings
Submitter Simon Baatz
Date Jan. 15, 2012, 8:32 p.m.
Message ID <b54d73556cba493e6d57c92873a67d77483f6f13.1326658542.git.gmbnomis@gmail.com>
Download mbox | patch
Permalink /patch/136209/
State Accepted
Commit a6689be84fdeb0caa8c5bf1a730c18d47bd12859
Headers show

Comments

Simon Baatz - Jan. 15, 2012, 8:32 p.m.
The peudonym identity should use a realm in environments where a realm is
used.  Thus, the realm of the permanent identity is added to the pseudonym
username sent by the server.

Signed-hostap: Simon Baatz <gmbnomis@gmail.com>
---
 src/eap_peer/eap_sim.c |   41 +++++++++++++++++++++++++++++++----------
 1 files changed, 31 insertions(+), 10 deletions(-)

Patch

diff --git a/src/eap_peer/eap_sim.c b/src/eap_peer/eap_sim.c
index 06fbc5b..f66f817 100644
--- a/src/eap_peer/eap_sim.c
+++ b/src/eap_peer/eap_sim.c
@@ -287,24 +287,44 @@  static void eap_sim_clear_identities(struct eap_sim_data *data, int id)
 }
 
 
-static int eap_sim_learn_ids(struct eap_sim_data *data,
+static int eap_sim_learn_ids(struct eap_sm *sm,
+                             struct eap_sim_data *data,
 			     struct eap_sim_attrs *attr)
 {
 	if (attr->next_pseudonym) {
+                const u8 *identity = NULL;
+                size_t identity_len = 0;
+                const u8 *realm = NULL;
+                size_t realm_len = 0;
+                
+                wpa_hexdump_ascii(MSG_DEBUG,
+				  "EAP-SIM: (encr) AT_NEXT_PSEUDONYM",
+				  attr->next_pseudonym,
+				  attr->next_pseudonym_len);
 		os_free(data->pseudonym);
-		data->pseudonym = os_malloc(attr->next_pseudonym_len);
+		/* Look for the realm of the permanent identity */
+		identity = eap_get_config_identity(sm, &identity_len);
+		if (identity) {
+    		        for (realm = identity, realm_len = identity_len; 
+                             realm_len > 0; realm_len--, realm++) {
+                                 if (*realm == '@') break;       
+                        }
+                }
+		data->pseudonym = os_malloc(attr->next_pseudonym_len 
+                                            + realm_len);
 		if (data->pseudonym == NULL) {
 			wpa_printf(MSG_INFO, "EAP-SIM: (encr) No memory for "
 				   "next pseudonym");
+                        data->pseudonym_len = 0;
 			return -1;
 		}
 		os_memcpy(data->pseudonym, attr->next_pseudonym,
 			  attr->next_pseudonym_len);
-		data->pseudonym_len = attr->next_pseudonym_len;
-		wpa_hexdump_ascii(MSG_DEBUG,
-				  "EAP-SIM: (encr) AT_NEXT_PSEUDONYM",
-				  data->pseudonym,
-				  data->pseudonym_len);
+                if (realm_len) {
+                        os_memcpy(data->pseudonym + attr->next_pseudonym_len, 
+                                    realm, realm_len);
+                }
+		data->pseudonym_len = attr->next_pseudonym_len + realm_len;
 	}
 
 	if (attr->next_reauth_id) {
@@ -313,7 +333,8 @@  static int eap_sim_learn_ids(struct eap_sim_data *data,
 		if (data->reauth_id == NULL) {
 			wpa_printf(MSG_INFO, "EAP-SIM: (encr) No memory for "
 				   "next reauth_id");
-			return -1;
+                        data->reauth_id_len = 0;
+ 			return -1;
 		}
 		os_memcpy(data->reauth_id, attr->next_reauth_id,
 			  attr->next_reauth_id_len);
@@ -663,7 +684,7 @@  static struct wpabuf * eap_sim_process_challenge(struct eap_sm *sm,
 			return eap_sim_client_error(
 				data, id, EAP_SIM_UNABLE_TO_PROCESS_PACKET);
 		}
-		eap_sim_learn_ids(data, &eattr);
+		eap_sim_learn_ids(sm, data, &eattr);
 		os_free(decrypted);
 	}
 
@@ -861,7 +882,7 @@  static struct wpabuf * eap_sim_process_reauthentication(
 				   data->nonce_s, data->mk, data->msk,
 				   data->emsk);
 	eap_sim_clear_identities(data, CLEAR_REAUTH_ID | CLEAR_EAP_ID);
-	eap_sim_learn_ids(data, &eattr);
+	eap_sim_learn_ids(sm, data, &eattr);
 
 	if (data->result_ind && attr->result_ind)
 		data->use_result_ind = 1;